Skip to content

Rollup of 7 pull requests #33204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Apr 26, 2016
Merged

Rollup of 7 pull requests #33204

merged 16 commits into from
Apr 26, 2016

Conversation

sanxiyn and others added 16 commits April 20, 2016 22:00
This used to be done to avoid inlining impls referencing private items,
but is now unnecessary since we actually check that impls do not
reference non-doc-reachable items.
An item is inlined and recorded as inlined even if it is
`doc(hidden)`, leading to unchecked external links.
Show previous definition of duplicate impl item

Fix rust-lang#32971.
…ichton

rustdoc: inline all the impls

This used to be done to avoid inlining impls referencing private items, but is now unnecessary since we actually check that impls do not reference non-doc-reachable items.

fixes rust-lang#32881
fixes rust-lang#33025
fixes rust-lang#33113

r? @alexcrichton
… r=alexcrichton

show unstable status for deprecated items

Fixes rust-lang#32374.
clarify documentation of TcpStream::connect() for multiple valid addresses

I am not sure how the UDP part of the stdlib behaves when passing multiple valid addresses, but it should be mentioned as there are legit use cases for [`impl<'a> ToSocketAddrs for &'a [SocketAddr]`](http://doc.rust-lang.org/nightly/std/net/trait.ToSocketAddrs.html), a TCP fallback only being one.

Just a little example program for anyone willing to enhance the documentation further:

```rust
use std::net::SocketAddr;
use std::net::ToSocketAddrs;
use std::net::TcpStream;

fn main()
{
	let v: Vec<SocketAddr> = vec!
	[
		"127.0.0.1:1338".to_socket_addrs().unwrap().next().unwrap(),
		"127.0.0.1:1337".to_socket_addrs().unwrap().next().unwrap(),
		"127.0.0.1:1339".to_socket_addrs().unwrap().next().unwrap(),
	];

	let stream = TcpStream::connect(&v[..]).unwrap();
}
```
rustdoc: Improve accessibility of rustdoc pages

fixes rust-lang#33131

r? @alexcrichton
@Manishearth
Copy link
Member Author

@bors r+ p=10

@bors
Copy link
Collaborator

bors commented Apr 25, 2016

📌 Commit 3dc0b55 has been approved by Manishearth

@Manishearth Manishearth assigned Manishearth and unassigned emberian Apr 25, 2016
@bors
Copy link
Collaborator

bors commented Apr 25, 2016

⌛ Testing commit 3dc0b55 with merge 149cf77...

bors added a commit that referenced this pull request Apr 25, 2016
Rollup of 7 pull requests

- Successful merges: #33107, #33133, #33160, #33167, #33194, #33196, #33200
- Failed merges:
@bors
Copy link
Collaborator

bors commented Apr 25, 2016

💔 Test failed - auto-win-msvc-32-opt

@alexcrichton
Copy link
Member

@bors: retry

On Mon, Apr 25, 2016 at 3:25 PM, bors [email protected] wrote:

[image: 💔] Test failed - auto-win-msvc-32-opt
http://buildbot.rust-lang.org/builders/auto-win-msvc-32-opt/builds/3164


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#33204 (comment)

@Manishearth
Copy link
Member Author

@bors force

@bors
Copy link
Collaborator

bors commented Apr 26, 2016

💔 Test failed - auto-linux-64-x-android-t

@Manishearth
Copy link
Member Author

@bors retry force

looks like gdb went boom?

@Manishearth
Copy link
Member Author

@bors retry force

@bors
Copy link
Collaborator

bors commented Apr 26, 2016

💔 Test failed - auto-linux-64-x-android-t

@Manishearth
Copy link
Member Author

@bors retry p=9

@bors
Copy link
Collaborator

bors commented Apr 26, 2016

⌛ Testing commit 3dc0b55 with merge 41028de...

bors added a commit that referenced this pull request Apr 26, 2016
Rollup of 7 pull requests

- Successful merges: #33107, #33133, #33160, #33167, #33194, #33196, #33200
- Failed merges:
@bors bors merged commit 3dc0b55 into rust-lang:master Apr 26, 2016
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants