Skip to content

rustdoc: Improve accessibility of rustdoc pages #33194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2016
Merged

rustdoc: Improve accessibility of rustdoc pages #33194

merged 1 commit into from
Apr 26, 2016
+4 −3

Conversation

mitaa
Copy link
Contributor

@mitaa mitaa commented Apr 25, 2016

@durka
Copy link
Contributor

durka commented Apr 25, 2016

Can we test this? Is there some tool that pulls out elements in the same order that screen readers do, and we can check the order?

@mitaa
Copy link
Contributor Author

mitaa commented Apr 25, 2016

preview is available here

@durka
Not sure, I've tested this using ChromeVox which exhibited the same behaviour as described in the referenced issue.

cc @camlorn

@alexcrichton
Copy link
Member

@bors: r+ bb9ec82

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 25, 2016
@Manishearth
Rollup merge of rust-lang#33194 - mitaa:rdoc-a, r=alexcrichton
b50a2ff 
rustdoc: Improve accessibility of rustdoc pages

fixes rust-lang#33131

r? @alexcrichton
@Manishearth Manishearth mentioned this pull request Apr 25, 2016
Merged
bors added a commit that referenced this pull request Apr 25, 2016
@bors
Auto merge of #33204 - Manishearth:rollup, r=Manishearth
149cf77 
Rollup of 7 pull requests

- Successful merges: #33107, #33133, #33160, #33167, #33194, #33196, #33200
- Failed merges:
bors added a commit that referenced this pull request Apr 26, 2016
@bors
Auto merge of #33204 - Manishearth:rollup, r=Manishearth
41028de 
Rollup of 7 pull requests

- Successful merges: #33107, #33133, #33160, #33167, #33194, #33196, #33200
- Failed merges:
@bors bors merged commit bb9ec82 into rust-lang:master Apr 26, 2016
@mitaa mitaa deleted the rdoc-a branch April 26, 2016 08:58
@ahicks92
Copy link
Contributor

This appears to do it for Firefox and NVDA, my combination.

It's not testable though, no. Not as far as I know. In my experience, 99% of the time it's DOM order. But I'm not confident enough on that to say 100% of the time because there's at least 12 combinations just for Windows now and I'm only on one of them. Screen readers and accessibility and the like are the least specified and least implemented web technologies, and even basic stuff essentially requires testing all of the combinations that you care about.

Thanks for the quick turnaround. This improves usability a lot. Usually I report stuff and it's just like "We'll do it sometime", where actually they mean never. I hate that I can only report for something like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: fix the order of items in method headers for screen reader users
5 participants
@mitaa @durka @alexcrichton @ahicks92 @bors