Skip to content

Fix 1.88 relnotes #143059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix 1.88 relnotes #143059

wants to merge 3 commits into from
+10 −2

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Jun 26, 2025 •
edited
Loading

  • Use stable std links for impl Default for {*const,*mut} T
  • Add missing relnotes for Stabilize slice_as_chunks library feature #139656 
    impl [T] {
    const fn as_chunks<const N: usize>(&self) -> (&[[T; N]], &[T]);
    const fn as_rchunks<const N: usize>(&self) -> (&[T], &[[T; N]]);
    const unsafe fn as_chunks_unchecked<const N: usize>(&self) -> &[[T; N]];
    const fn as_chunks_mut<const N: usize>(&mut self) -> (&mut [[T; N]], &mut [T]);
    const fn as_rchunks_mut<const N: usize>(&mut self) -> (&mut [T], &mut [[T; N]]);
    const unsafe fn as_chunks_unchecked_mut<const N: usize>(&mut self) -> &mut [[T; N]];
}
  • Add missing mod ffi::c_str and hint::select_unpredictable

r? @cuviper

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Jun 26, 2025
@jieyouxu jieyouxu mentioned this pull request Jun 26, 2025
Merged
cuviper
cuviper requested changes Jun 26, 2025
View reviewed changes
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2025
@jieyouxu
Copy link
Member Author

Addressed review comments.
@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 26, 2025
@cuviper
Copy link
Member

cuviper commented Jun 26, 2025

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 26, 2025

📌 Commit 0c1c648 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2025
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jun 27, 2025
@compiler-errors
Rollup merge of rust-lang#143059 - jieyouxu:slice-as-chunks, r=cuviper
93810c9 
Fix 1.88 relnotes

- Use stable std links for `impl Default for {*const,*mut} T`
- Add missing relnotes for rust-lang#139656
    ```rs
    impl [T] {
        const fn as_chunks<const N: usize>(&self) -> (&[[T; N]], &[T]);
        const fn as_rchunks<const N: usize>(&self) -> (&[T], &[[T; N]]);
        const unsafe fn as_chunks_unchecked<const N: usize>(&self) -> &[[T; N]];
        const fn as_chunks_mut<const N: usize>(&mut self) -> (&mut [[T; N]], &mut [T]);
        const fn as_rchunks_mut<const N: usize>(&mut self) -> (&mut [T], &mut [[T; N]]);
        const unsafe fn as_chunks_unchecked_mut<const N: usize>(&mut self) -> &mut [[T; N]];
    }
    ```
- Add missing `mod ffi::c_str` and `hint::select_unpredictable`

r? `@cuviper`
@compiler-errors compiler-errors mentioned this pull request Jun 27, 2025
Open
bors added a commit that referenced this pull request Jun 27, 2025
@bors
Auto merge of #143074 - compiler-errors:rollup-cv64hdh, r=compiler-er…
e61dd43 
…rors

Rollup of 18 pull requests

Successful merges:

 - #137843 (make RefCell unstably const)
 - #140942 (const-eval: allow constants to refer to mutable/external memory, but reject such constants as patterns)
 - #142549 (small iter.intersperse.fold() optimization)
 - #142637 (Remove some glob imports from the type system)
 - #142647 ([perf] Compute hard errors without diagnostics in impl_intersection_has_impossible_obligation)
 - #142700 (Remove incorrect comments in `Weak`)
 - #142927 (Add note to `find_const_ty_from_env`)
 - #142967 (Fix RwLock::try_write documentation for WouldBlock condition)
 - #142986 (Port `#[export_name]` to the new attribute parsing infrastructure)
 - #143001 (Rename run always )
 - #143010 (Update `browser-ui-test` version to `0.20.7`)
 - #143015 (Add `sym::macro_pin` diagnostic item for `core::pin::pin!()`)
 - #143033 (Expand const-stabilized API links in relnotes)
 - #143041 (Remove cache for citool)
 - #143056 (Move an ACE test out of the GCI directory)
 - #143059 (Fix 1.88 relnotes)
 - #143067 (Tracking issue number for `iter_macro`)
 - #143073 (Fix some fixmes that were waiting for let chains)

Failed merges:

 - #143020 (codegen_fn_attrs: make comment more precise)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuviper cuviper cuviper requested changes

Assignees

@cuviper cuviper

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jieyouxu @cuviper @bors @rustbot