Announcing Rust 1.88.0 #1651
Announcing Rust 1.88.0 #1651
Conversation
|
Hi relnotes-interest-group, this PR adds a release blog post. Could you review cc @alex-semenyuk @jieyouxu @joshtriplett @Kobzol @lcnr @traviscross |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: 许杰友 Jieyou Xu (Joe) <[email protected]> Co-authored-by: Jubilee <[email protected]> Co-authored-by: Trevor Gross <[email protected]>
Expand const-stabilized API links in relnotes Noticed while looking at the relnotes blog post rust-lang/blog.rust-lang.org#1651 (comment). r? `@cuviper`
Expand const-stabilized API links in relnotes Noticed while looking at the relnotes blog post rust-lang/blog.rust-lang.org#1651 (comment). r? ``@cuviper``
Expand const-stabilized API links in relnotes Noticed while looking at the relnotes blog post rust-lang/blog.rust-lang.org#1651 (comment). r? ```@cuviper```
Co-authored-by: 许杰友 Jieyou Xu (Joe) <[email protected]>
|
Deployment is done! 🚀 |
|
|
||
| ```rust | ||
| #[unsafe(naked)] | ||
| pub unsafe extern "sysv64" fn wrapping_add(a: u64, b: u64) { |
There was a problem hiding this comment.
Should this have a return type?
pub unsafe extern "sysv64" fn wrapping_add(a: u64, b: u64) -> u64 {
There was a problem hiding this comment.
it should (technically it's okay as it is, but it is confusing and unintentional)
There was a problem hiding this comment.
Please feel free to send a PR correction!
| pub unsafe extern "sysv64" fn wrapping_add(a: u64, b: u64) { | ||
| // Equivalent to `a.wrapping_add(b)`. | ||
| core::arch::naked_asm!( | ||
| "add rax, rdi, rsi", |
There was a problem hiding this comment.
This does not seem valid in x86-64 which only has 2-operand add. Or does it mean something like:
| "add rax, rdi, rsi", | |
| "lea rax, [rdi + rsi]", |
(not checked)
There was a problem hiding this comment.
ah, I've been led astray by godbolt, which will assembly the 3-operand add, but fail to execute it. I tried to not use lea just because add is more clear, but now to use the 2-operand add you'd have to mov. Also there is just a rdi + rsi in there so it's probably sufficiently clear.
fix at #1654
Expand const-stabilized API links in relnotes Noticed while looking at the relnotes blog post rust-lang/blog.rust-lang.org#1651 (comment). r? ````@cuviper````
Rollup merge of #143033 - jieyouxu:expand-apis, r=cuviper Expand const-stabilized API links in relnotes Noticed while looking at the relnotes blog post rust-lang/blog.rust-lang.org#1651 (comment). r? ````@cuviper````
cc @rust-lang/release
@rustbot ping relnotes-interest-group
Rendered