Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add must_use on pointer equality functions #116351

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Add must_use on pointer equality functions #116351

merged 1 commit into from
Oct 3, 2023

Conversation

asquared31415
Copy link
Contributor

ptr == ptr (like all use of ==) has a similar warning, and these functions are simple convenience wrappers over that.

@rustbot
Copy link
Collaborator

rustbot commented Oct 2, 2023

r? @m-ou-se

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 2, 2023
@workingjubilee
Copy link
Member

sgtm.
@bors r+

@bors
Copy link
Contributor

bors commented Oct 2, 2023

📌 Commit 34ea540 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 2, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 3, 2023
Merged
@bors bors merged commit cebe393 into rust-lang:master Oct 3, 2023
@rustbot rustbot added this to the 1.75.0 milestone Oct 3, 2023
@asquared31415 asquared31415 deleted the ptr_eq_must_use branch October 3, 2023 17:21
@pvdrz pvdrz mentioned this pull request Oct 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@m-ou-se m-ou-se

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.75.0
Development

Successfully merging this pull request may close these issues.
5 participants
@asquared31415 @rustbot @workingjubilee @bors @m-ou-se