Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor out common token generation in fluent_messages. #116328

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Factor out common token generation in fluent_messages. #116328

merged 2 commits into from
Oct 3, 2023

Conversation

nnethercote
Copy link
Contributor

The failure and success cases are similar enough that they can share code.

r? @davidtwco

@nnethercote
Factor out common token generation in fluent_messages.
5f4177a 
The failure and success cases are similar enough that they can share
code.
@nnethercote
Fix a comment.
57397de 
Compiling any part of the compiler will almost certainly require
Nightly.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 2, 2023
@davidtwco
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 3, 2023

📌 Commit 57397de has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 3, 2023
Merged
@bors bors merged commit 5dd9313 into rust-lang:master Oct 3, 2023
@rustbot rustbot added this to the 1.75.0 milestone Oct 3, 2023
@nnethercote nnethercote deleted the rustc_fluent_macro branch October 3, 2023 20:36
@pvdrz pvdrz mentioned this pull request Oct 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.75.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nnethercote @davidtwco @bors @rustbot