Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: remove no-op CSS .content .item-info { position: relative } #102125

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

notriddle
Copy link
Contributor

@notriddle notriddle commented Sep 22, 2022

This rule was added to help position the marker line in 110e727, which was a position: absolute pseudo-element that relied on its parent to put it in the right spot. (it was changed from a line to an arrow in 1ffb9cf, then a different arrow in ae3a53f).

The arrow was removed in 73d0f7c, so the relative position is no longer necessary.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Sep 22, 2022
@rustbot
Copy link
Collaborator

rustbot commented Sep 22, 2022

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 22, 2022
This rule was added to help position the marker line in
110e727, which was a `position: absolute`
pseudo-element that relied on its parent to put it in the right spot.

The arrow was removed in 73d0f7c, so the
`relative` position is no longer necessary.
@notriddle notriddle force-pushed the notriddle/content-item-info branch from 04f97a1 to 876c707 Compare September 22, 2022 04:55
@GuillaumeGomez
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 22, 2022

📌 Commit 876c707 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 23, 2022
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#102113 (OpTy: fix a method taking self rather than &self)
 - rust-lang#102118 (rustdoc: clean up line numbers on code examples)
 - rust-lang#102123 (Add note to clippy::non_expressive_names doc)
 - rust-lang#102125 (rustdoc: remove no-op CSS `.content .item-info { position: relative }`)
 - rust-lang#102127 (Use appropriate variable names)
 - rust-lang#102128 (Const unification is already infallible, remove the error handling logic)
 - rust-lang#102133 (Use valtrees for comparison)
 - rust-lang#102135 (Improve some AllTypes fields name)
 - rust-lang#102144 (Extend const_convert with const {FormResidual, Try} for ControlFlow.)
 - rust-lang#102147 (rustdoc: remove no-op CSS `.location:empty { border: none }`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit dee0c42 into rust-lang:master Sep 23, 2022
@rustbot rustbot added this to the 1.66.0 milestone Sep 23, 2022
@notriddle notriddle deleted the notriddle/content-item-info branch September 23, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants