rustdoc: clean up line numbers on code examples #102118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`display: inline-flex` was used as part of e961d39, the original commit that added these line numbers. Does anyone know why it was done this way?
rustbot
added
the
T-rustdoc
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @CraftSpider (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
notriddle
force-pushed
the
notriddle/line-numbers
branch
from
df39b76 to
f66769f
Compare
| @@ -10,7 +10,7 @@ assert-property: ("html", {"scrollTop": "0"}) | |||
| click: '//a[text() = "barbar"]' | |||
| assert-property: ("html", {"scrollTop": "125"}) | |||
| click: '//a[text() = "bar"]' | |||
| assert-property: ("html", {"scrollTop": "166"}) | |||
| assert-property: ("html", {"scrollTop": "156"}) | |||
There was a problem hiding this comment.
Line wrapping changed because of the slightly wider header box.
There was a problem hiding this comment.
Well I guess it's a good thing then!
|
Apart from my question, it looks great! |
GuillaumeGomez
approved these changes
Sep 22, 2022
|
Thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 23, 2022
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#102113 (OpTy: fix a method taking self rather than &self) - rust-lang#102118 (rustdoc: clean up line numbers on code examples) - rust-lang#102123 (Add note to clippy::non_expressive_names doc) - rust-lang#102125 (rustdoc: remove no-op CSS `.content .item-info { position: relative }`) - rust-lang#102127 (Use appropriate variable names) - rust-lang#102128 (Const unification is already infallible, remove the error handling logic) - rust-lang#102133 (Use valtrees for comparison) - rust-lang#102135 (Improve some AllTypes fields name) - rust-lang#102144 (Extend const_convert with const {FormResidual, Try} for ControlFlow.) - rust-lang#102147 (rustdoc: remove no-op CSS `.location:empty { border: none }`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit switches from
display: inline-flex; width: 100%todisplay: flex.display: inline-flexwas used as part of e961d39, the original commit that added these line numbers. Does anyone know why it was done this way?Second commit makes it so that toggling this checkbox will update the page in real time, just like changing themes does.
Preview: https://notriddle.com/notriddle-rustdoc-test/line-numbers/std/vec/struct.Vec.html