This repository was archived by the owner on Nov 7, 2022. It is now read-only.
barrier functions wrap unsafe behaviour #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The safety documentation for the barrier functions just say "In your own hands, this is hardware land!" because the programmer doesn't need to check safety when adding a barrier. Adding a memory barrier does not break the borrow checker, cause undefined behaviour or alter memory in any way. Therefore, we can make dsb(), dmb() and isb() safe wrappers around the asm code that write the intended assembly.
|
Coincidentally, I have prepared this change already in https://github.com/rust-embedded/cortex-a/tree/safe_barrier and it will go into the next release. |
|
Next release schedule explained in #46 (comment) |
|
Closing in favor of #48 |
|
Perfect, good timing! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The safety documentation for the barrier functions just say "In your own hands, this is hardware land!" because the programmer doesn't need to check safety when adding a barrier. Adding a memory barrier does not break the borrow checker, cause undefined behaviour or alter memory in any way. Therefore, we can make dsb(), dmb() and isb() safe wrappers around the asm code that write the intended assembly.