Skip to content
This repository was archived by the owner on Nov 7, 2022. It is now read-only.

Update tock-registers dependency to 0.8 #46

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

berkus
Copy link
Member

@berkus berkus commented Sep 17, 2022

Update for the new version of tock-registers.

@andre-richter
Copy link
Member

Lazy question from my side: Will it break anything?

@berkus
Copy link
Member Author

berkus commented Sep 17, 2022

Does not seem so, the only breaking change touches try_from -> try_from_value and that is not used in cortex-a.

Can't really test on my OS, because cortex-a dependency on 0.7 breaks the build so far (too lazy to do manual overrides, don't ask).

@andre-richter
Copy link
Member

I am currently pondering if this justifies a new major release of cortex-a, since the user is encouraged to bump the tock-registers dependency of the user's project in tandem, and it contains a breaking change.

@berkus
Copy link
Member Author

berkus commented Sep 19, 2022

I believe it does, semver and all that...

@andre-richter andre-richter merged commit 2a5ca5a into rust-embedded:master Sep 19, 2022
@andre-richter
Copy link
Member

I am seeing some issues with the 0.8 tock version when trying this out locally (tock/tock#3228). Please give me some time to dig around before we indirectly force people to switch to it due to cortex-a.

@berkus
Copy link
Member Author

berkus commented Sep 20, 2022

@andre-richter alright, I will get to testing it more with my code this week as well.

@andre-richter
Copy link
Member

Let’s go directly to 0.8.1, so pending tock/tock#3242.

Since it will be a breaking change due to the tock upgrade anyways, I’ll take the opportunity to also include 9421f40. This has been bugging me for some time now.

@berkus berkus deleted the update-tock-registers branch September 26, 2022 21:01
@berkus
Copy link
Member Author

berkus commented Sep 26, 2022

👍🏼

@berkus
Copy link
Member Author

berkus commented Sep 26, 2022

Well, my code here broke because of tock/tock#3088 - making this a major release was a good call.

Error is

     |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the evaluated program panicked at 'Invalid size for struct RegisterBlock (expected 244, actual struct size differs)', machine/src/platform/rpi3/gpio.rs:33:1
     |
    ::: /Users/berkus/.cargo/registry/src/6github.com-1ecc6299db9ec823/tock-registers-0.8.1/src/macros.rs:165:1

So it's conveniently reports what I already know (the address of @EnD marker, but doesn't tell what it should be, in its opinion). Should be easy to fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants