Tags: rootulp/celestia-core
Tags
fix(mempool/v1): data race (celestiaorg#1655) Closes celestiaorg/celestia-app#4379 I don't know if this fixes all the issues with the v1 mempool but it should fix the data race reported in the issue. We had to move the mempool lock earlier in `CheckTx` before this map look up ```go txmp.txByKey[txKey] ``` ## Testing ```shell # Before $ go test ./mempool/v1 -race -run TestConcurrentCheckTxDataRace # github.com/tendermint/tendermint/mempool/v1.test ================== WARNING: DATA RACE Write at 0x00c0005987e0 by goroutine 89: # After $ go test ./mempool/v1 -race -run TestConcurrentCheckTxDataRace # github.com/tendermint/tendermint/mempool/v1.test ok github.com/tendermint/tendermint/mempool/v1 (cached) ```
feat!: add ShareVersion field to blob (celestiaorg#890) * feat!: add ShareVersion field to blob * fix: lint * fix: lint (again) * make proto-gen * refactor: remove conditional * refactor: consolidate test cases * chore: add missing newlines * chore: add nil proto test case * chore: add test case with two blobs
fix: patch data race (celestiaorg#869) * fix: protect global var with a sync.Once * fix: use a mutex instead of sync.Once to allow for arbitrary swapping of the env * fix: implement and use GetEnvironment * fix: lint by disabling lll * fix: invoke GetEnvironment() once per function scope * remove //nolint:lll * make proto-gen Co-authored-by: Rootul Patel <[email protected]>
fix: comment for blobs (celestiaorg#886) Addresses this feedback https://github.com/celestiaorg/celestia-core/pull/879/files#r1020196368
chore!: rename blockdata.Messages -> blockdata.Blobs (celestiaorg#879) * chore!: rename Messages -> blobs * fix: adjust tests now that there is less overhead * review: feedback Co-authored-by: Rootul P <[email protected]> * chore; docs Co-authored-by: Rootul P <[email protected]>
fix: use a mutex instead of sync.Once to allow for arbitrary swapping… … of the env
breaking!: move share consts to celestia-app (celestiaorg#861) * breaking: move share consts to celestia-app Closes celestiaorg#841 * remove remaining consts that are not used in celestia-core
feat: add share index to malleated (wrapped) txs (celestiaorg#819) * feat: add share index to malleated (wrapped) txs pass the share index when wrapping * chore: refactor unrwap function to return the entire malleated tx * fix compile issue
PreviousNext