Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mempool/v1): data race #1655

Merged
merged 4 commits into from
Mar 5, 2025
Merged

fix(mempool/v1): data race #1655

merged 4 commits into from
Mar 5, 2025
+89 −5

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Mar 5, 2025 •
edited
Loading

Closes celestiaorg/celestia-app#4379

I don't know if this fixes all the issues with the v1 mempool but it should fix the data race reported in the issue. We had to move the mempool lock earlier in CheckTx before this map look up

txmp.txByKey[txKey]

Testing

# Before
$ go test ./mempool/v1 -race -run TestConcurrentCheckTxDataRace
# github.com/tendermint/tendermint/mempool/v1.test
==================
WARNING: DATA RACE
Write at 0x00c0005987e0 by goroutine 89:

# After
$ go test ./mempool/v1 -race -run TestConcurrentCheckTxDataRace
# github.com/tendermint/tendermint/mempool/v1.test
ok  	github.com/tendermint/tendermint/mempool/v1	(cached)

rootulp added 2 commits March 5, 2025 12:59
@rootulp
test: failing TestConcurrentCheckTxDataRace
f87c190 
Run it with go test ./mempool/v1 -race -run TestConcurrentCheckTxDataRace
@rootulp
fix: lock before txByKey lookup
Loading
Loading status checks…
dcc3431
@rootulp rootulp requested review from cmwaters and evan-forbes March 5, 2025 18:02
@rootulp rootulp self-assigned this Mar 5, 2025
@rootulp
fix: lint
Loading
Loading status checks…
b8c6160
@rootulp
fix: comment
Loading
Loading status checks…
0c825d2
@rootulp rootulp marked this pull request as ready for review March 5, 2025 18:08
@rootulp rootulp requested a review from a team as a code owner March 5, 2025 18:08
@rootulp rootulp mentioned this pull request Mar 5, 2025
Closed
evan-forbes
evan-forbes approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@rootulp rootulp merged commit 1d1d65b into celestiaorg:v0.34.x-celestia Mar 5, 2025
17 checks passed
@rootulp rootulp mentioned this pull request Mar 5, 2025
Merged
rootulp added a commit to celestiaorg/celestia-app that referenced this pull request Mar 6, 2025
@rootulp
fix: v1 mempool data race (#4380)
Loading
Loading status checks…
a3917ec 
Closes #4379 by
upgrading to
https://github.com/celestiaorg/celestia-core/releases/tag/v1.49.1-tm-v0.34.35
which includes celestiaorg/celestia-core#1655
mergify bot pushed a commit to celestiaorg/celestia-app that referenced this pull request Mar 6, 2025
@rootulp @mergify
fix: v1 mempool data race (#4380)
Loading
Loading status checks…
2a6aab3 
Closes #4379 by
upgrading to
https://github.com/celestiaorg/celestia-core/releases/tag/v1.49.1-tm-v0.34.35
which includes celestiaorg/celestia-core#1655

(cherry picked from commit a3917ec)

# Conflicts:
#	go.mod
#	go.sum
#	test/interchain/go.mod
@mergify mergify bot mentioned this pull request Mar 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-forbes evan-forbes

@cmwaters cmwaters

Assignees

@rootulp rootulp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validator node panics with "fatal error: concurrent map read and map write"
2 participants
@rootulp @evan-forbes