Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mini-migrator for xz->liblzma-devel #3375

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

xhochy
Copy link
Member

@xhochy xhochy commented Dec 10, 2024

Description:

Mini-Migrator to rename xz to liblzma-devel if xz is listed in host.

Checklist:

  • Pydantic model updated or no update needed

Cross-refs, links to issues, etc:

Fixes #3318

@xhochy xhochy force-pushed the xz-liblzma-migrator branch from e3adac7 to 40375cf Compare December 10, 2024 21:06
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.64%. Comparing base (f501bdd) to head (40375cf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
conda_forge_tick/make_migrators.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3375      +/-   ##
==========================================
+ Coverage   76.59%   76.64%   +0.04%     
==========================================
  Files         130      132       +2     
  Lines       14235    14274      +39     
==========================================
+ Hits        10904    10941      +37     
- Misses       3331     3333       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xhochy xhochy marked this pull request as ready for review December 10, 2024 21:19
@xhochy
Copy link
Member Author

xhochy commented Dec 10, 2024

fyi @fhoehle, @jakirkham @nicoddemus. This should remove of the dependencies on xz-gpl-tools where those are not needed.

@beckermr
Copy link
Contributor

LGTM! Thank you!

@beckermr beckermr merged commit e0be001 into regro:main Dec 10, 2024
8 checks passed
@jakirkham
Copy link
Contributor

Thanks Uwe and Matt! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mini-migrator to replace xz with liblzma-devel in host
3 participants