Migrator for xorg-*proto to xorg-xorgproto

[jakirkham]

Packages matching xorg-*proto (excluding xorg-xorgproto) are deprecated

Users are recommended to migrate to xorg-xorgproto

One exception to the above is xorg-xcb-proto, which is also deprecated, but should instead be replaced by xcb-proto

The linter now warns about this situation:

• Provide a linter hint for xorg-proto packages conda-forge/conda-forge-pinning-feedstock#6688
• Hint for all other xorg-*protos conda-forge/conda-forge-pinning-feedstock#6816

Would it make sense to put together a migrator of some kind to manage this transition with the bot?

[hmaarrfk]

There are a few other proto packages that can be caught by the migrator.
https://github.com/search?q=org%3Aconda-forge+xorg-+proto+language%3AYAML&type=code&l=YAML

once the core logic is in, then a cursory search through the first few pages might expand the ability to catch even more.

[hmaarrfk]

• xorg-xineramaproto
• xorg-xproto
• xorg-xf86vidmodeproto
• xorg-xextproto
• xorg-glproto
• xorg-inputproto
• xorg-kbproto

[jakirkham]

Should we add linter hints for those as well?

[hmaarrfk]

i mean we could, but its somewhat "low importance". Don't we already have a migrator for package renaming?

we could migrate all the proto packages that we find in: https://conda-forge.org/packages/

[jakirkham]

Am not aware of an existing migrator. Hence the issue raised here to add one

At least currently see issues with clobbering when trying to install some packages from conda-forge. That would be nice to fix

[hmaarrfk]

yeah i misremembered sorry. it was the whole piggyback minimigrator stuff and complications...

[jakirkham]

So in general are we just want to migrate xorg-*proto to xorg-xorgproto?

[hmaarrfk]

correct.

[jakirkham]

Thanks Mark! 🙏

Updated the issue to reflect this

[jakirkham]

Should we add linter hints for those as well?

Extended the hints to these packages and anything else referencing xorg-*proto except xorg-xorgproto

xref: conda-forge/conda-forge-pinning-feedstock#6816

[hmaarrfk]

see conda-forge/conda-forge-pinning-feedstock#6822 for how to implement such a migrator.

[jakirkham]

Think we would also need bot changes

For example: #3375

[hmaarrfk]

yes i shared the "link" above as a thread for somebody to pull on in case they were so inclined to implement things!

[mgorny]

I think we should combine all existing package migrators (found at least JpegTurboMigrator, QtQtMainMigrator and XzLibLzmaDevelMigrator) to a single class with a package mapping. Right now they're pretty identical.

[beckermr]

Those migrators get applied to only some migrations and not others. We can have a single class, but we need to instantiate separate objects for each one with specific migrations in mind.

[mgorny]

Yeah, I see that now. Sorry, was still reading through the code. So yeah, I feel like a shared base class with the common logic should streamline things a bit.

[beckermr]

It is likely we only need a single class and not child classes. For example, the Replacement migrator is customized on instantiating as opposed to making new child classes.

[mgorny]

Oh yes, looks like Replacement is pretty much what we need for "simple" cases. Though in case of xorg-*proto, we would probably want to deduplicate somehow.

[mgorny]

Oh wait, Replacement is a "big" Migrator, whereas these are MiniMigrators.