Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hint for all other xorg-*protos #6816

Merged

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Dec 9, 2024

Standardize and expand the xorg-*proto hints from PR: #6688

Covers all xorg-*protos (excluding xorg-xorgproto) with similar hints and recommends they be replaced with xorg-xorgproto


Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

Copy link
Contributor

@pkgw pkgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for going to the trouble for the full solution, here. One comment below.

Copy link
Member Author

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Peter! 🙏

Would these proposed changes capture what you are looking for?

@jakirkham jakirkham requested a review from pkgw December 11, 2024 05:57
@jakirkham jakirkham added the automerge Merge the PR when CI passes label Dec 13, 2024
@conda-forge-admin conda-forge-admin merged commit 4cf1b9d into conda-forge:main Dec 13, 2024
3 checks passed
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • github-actions: passed

Thus the PR was passing and merged! Have a great day!

@jakirkham jakirkham deleted the lint_xorg_protos branch December 13, 2024 03:56
@jakirkham
Copy link
Member Author

Thank you both! 🙏

Hoping this helps more people understand the changes needed and what to do next 🙂

@h-vetinari
Copy link
Member

Thanks all!

Hoping this helps more people understand the changes needed and what to do next 🙂

I think the one case we don't cover yet (and which is hard/impossible to do with the hints) is those cases where the various *proto packages were only present transitively. I ran into such a situation in conda-forge/cairo-feedstock#79, for example. Nothing to do for now, just noting this for completeness/visibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants