breaking: Remove secondary exports of cli-server-api #2584
Merged
+2
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
approved these changes
Jan 27, 2025
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Jan 28, 2025
Summary: Follows react-native-community/cli#2584. - Also add FIXME comment flagging potential core APIs gap without CLI. Changelog: [Internal] Differential Revision: D68766565
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Jan 28, 2025
Summary: Follows react-native-community/cli#2584. - Also add FIXME comment flagging potential core APIs gap without CLI. Changelog: [Internal] Differential Revision: D68766565
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Jan 28, 2025
Summary: Pull Request resolved: #48997 Follows react-native-community/cli#2584. - Also add FIXME comment flagging potential core APIs gap without CLI. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D68766565 fbshipit-source-id: 60747715f76c4323e306c39ab0613fb4818b4914
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Mar 6, 2025
Summary: Scope down type definitions to the subset of CLI we are currently explicitly referencing. Rename/bump to `19.x`. Related to: - facebook#45380 - react-native-community/cli#2584 - (others) Changelog: [Internal] Differential Revision: D70699083
react-native-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Mar 6, 2025
Summary: Pull Request resolved: #48997 Follows react-native-community/cli#2584. - Also add FIXME comment flagging potential core APIs gap without CLI. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D68766565 fbshipit-source-id: 60747715f76c4323e306c39ab0613fb4818b4914
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Mar 6, 2025
Summary: Scope down type definitions to the subset of CLI we are currently explicitly referencing. Rename/bump to `19.x`. Related to: - facebook#45380 - react-native-community/cli#2584 - (others) Changelog: [Internal] Reviewed By: rshest Differential Revision: D70699083
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Mar 6, 2025
Summary: Pull Request resolved: #49866 Scope down type definitions to the subset of CLI we are currently explicitly referencing. Rename/bump to `19.x`. Related to: - #45380 - react-native-community/cli#2584 - (others) Changelog: [Internal] Reviewed By: rshest Differential Revision: D70699083 fbshipit-source-id: 43af1b529d9b95f3d8ba955588af6a09367cdcea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Around #2583, I'm taking the opportunity to review the API boundary of the
cli-server-apipackage.indexPageMiddlewareis moved into the middleware stack returned bycreateDevServerMiddleware.Test Plan:
✅ Builds
✅ GitHub-wide code search to look for references to these imports outside of
react-native.Checklist