Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove rnc/cli-tools version & errors deps #45380

Closed
wants to merge 2 commits into from

Conversation

blakef
Copy link
Contributor

@blakef blakef commented Jul 11, 2024

Summary:
Removed the use of version checking and error code that is in react-native-community/cli-tools.

Changelog:
[Internal] [Changed] - Removed community-cli-plugin version & error dependencies

Differential Revision: D59378012

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jul 11, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59378012

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59378012

@blakef blakef force-pushed the export-D59378012 branch from 1fd00c8 to d4fec97 Compare July 11, 2024 16:32
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59378012

@blakef blakef force-pushed the export-D59378012 branch from d4fec97 to 2707c5c Compare July 12, 2024 12:31
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59378012

@blakef blakef force-pushed the export-D59378012 branch from 2707c5c to fa23de7 Compare July 12, 2024 12:58
Summary:
Removing the remaining dependencies from the react-native-community/*. This
inlines a copy of the logger.

Changelog:
[Internal][Changed] Removed react-native-community/cli-tools logger dependency

Differential Revision: D59378011
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59378012

@blakef blakef force-pushed the export-D59378012 branch from fa23de7 to f111aa9 Compare July 15, 2024 10:31
Summary:
Pull Request resolved: #45380

Removed the use of version checking and error code that is in react-native-community/cli-tools.

Changelog:
[Internal] [Changed] - Removed community-cli-plugin version & error dependencies

Reviewed By: robhogan

Differential Revision: D59378012
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59378012

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 9aaadd9.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jul 15, 2024
huntie added a commit to huntie/react-native that referenced this pull request Mar 6, 2025
Summary:
Scope down type definitions to the subset of CLI we are currently explicitly referencing. Rename/bump to `19.x`.

Related to:
- facebook#45380
- react-native-community/cli#2584
- (others)

Changelog: [Internal]

Differential Revision: D70699083
huntie added a commit to huntie/react-native that referenced this pull request Mar 6, 2025
Summary:
Scope down type definitions to the subset of CLI we are currently explicitly referencing. Rename/bump to `19.x`.

Related to:
- facebook#45380
- react-native-community/cli#2584
- (others)

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D70699083
facebook-github-bot pushed a commit that referenced this pull request Mar 6, 2025
Summary:
Pull Request resolved: #49866

Scope down type definitions to the subset of CLI we are currently explicitly referencing. Rename/bump to `19.x`.

Related to:
- #45380
- react-native-community/cli#2584
- (others)

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D70699083

fbshipit-source-id: 43af1b529d9b95f3d8ba955588af6a09367cdcea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants