Added Willow Cove #301
Added Willow Cove #301
Conversation
|
Added a detection for Willow Cove Client (Tiger Lake - client) |
|
@rrwinterton can you post some reference to the doc that says this number corresponds to Willow Cove? |
include/cpuinfo.h
Outdated
| @@ -353,6 +353,8 @@ enum cpuinfo_uarch { | |||
| cpuinfo_uarch_palm_cove = 0x0010020B, | |||
| /** Intel Sunny Cove microarchitecture (10 nm, Ice Lake). */ | |||
| cpuinfo_uarch_sunny_cove = 0x0010020C, | |||
| /** Intel Willow Cove (10 nm, Tiger Lake). */ | |||
| cpuinfo_uarch_willow_cove = 0x00100302, | |||
There was a problem hiding this comment.
Change constant to 0x0010020D for consistency with sunny_cove predecessor
src/x86/uarch.c
Outdated
| @@ -21,6 +21,8 @@ enum cpuinfo_uarch cpuinfo_x86_decode_uarch( | |||
| // systems | |||
| case 0x04: // Pentium MMX | |||
| return cpuinfo_uarch_p5; | |||
| case 0x06: // Tiger Lake, Alder Lake, Raptor Lake and Meteor Lake | |||
| return cpuinfo_uarch_ | |||
| @@ -168,6 +170,9 @@ enum cpuinfo_uarch cpuinfo_x86_decode_uarch( | |||
| case 0x7E: // Ice Lake-U | |||
| return cpuinfo_uarch_sunny_cove; | |||
|
|
|||
| case 0x8C: // Tiger U | |||
There was a problem hiding this comment.
note 8c = 140 is the one that sde -tgl exposes but https://en.wikichip.org/wiki/intel/cpuid confirms 141
| @@ -82,6 +82,8 @@ static const char* uarch_to_string(enum cpuinfo_uarch uarch) { | |||
| return "Sunny Cove"; | |||
| case cpuinfo_uarch_willamette: | |||
| return "Willamette"; | |||
| case cpuinfo_uarch_willow_cove: | |||
There was a problem hiding this comment.
move up 2 lines because willow cove is the successor to sunny cove (icelake)
|
Confirmed Tigerlake does not detect currently: Was With your change sde -tgl works: sde -tgl -- ./cpu-info | head If you have a real Tigerlake available, could you verify a package name? SDE seems to fill them in wrong Testing icelake, the predecessor of tigerlake, shows Sunny Cove. sde -icl -- ./cpu-info | head |
removed incomplete modification in naming
moved willow_cove up two lines to be next to sunny_cove
made the enum consistent with uarch naming following sunny_cove
|
Willow Cove is that micro architecture of Tiger Lake CPU's from Intel. Willow Cove architecture has an Intel Family 6, Model 0x8C or 0x8D. |
Added comments below and did fix of incomplete file per frank's comments. Intel Willow Cover is part of the Tiger Lake CPU family microarchitecture. Intel Family 6, Model 0x8C or 0x8D |
include/cpuinfo.h
Outdated
| @@ -353,6 +353,8 @@ enum cpuinfo_uarch { | |||
| cpuinfo_uarch_palm_cove = 0x0010020B, | |||
| /** Intel Sunny Cove microarchitecture (10 nm, Ice Lake). */ | |||
| cpuinfo_uarch_sunny_cove = 0x0010020C, | |||
| /** Intel Willow Cove (10 nm, Tiger Lake). */ | |||
There was a problem hiding this comment.
/** Intel Willow Cove microarchitecture (10 nm, Tiger Lake). */
updated comments to refer to intel microarchitecture per request to keep consistent.
|
@fbarchard i imerged #298. Can you rebase just to be sure. Then i can merge |
|
@rrwinterton @kimishpatel please please add links with references to the PR description next time before merging |
my bad @malfet @rrwinterton can you please add description in the PR as to references @malfet requested. Ideally you just embed it in the code |
* Added Willow Cove * Update uarch.c removed incomplete modification in naming * Update cpu-info.c moved willow_cove up two lines to be next to sunny_cove * Update cpuinfo.h made the enum consistent with uarch naming following sunny_cove * Update cpuinfo.h updated comments to refer to intel microarchitecture per request to keep consistent.
No description provided.