Skip to content

Add Intel Darkmont uarch #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 9, 2025
Merged

Add Intel Darkmont uarch #298

merged 4 commits into from
Jun 9, 2025

Conversation

fbarchard
Copy link
Collaborator

@fbarchard fbarchard commented May 30, 2025

  • Darkmont is the uarch used in Clearwater Forest

Tested:
make cpu-info
sde -cwf -- ./cpu-info
Packages:
0: Intel Xeon X5680
1: Intel Xeon X5680
Microarchitectures:
36x Darkmont
Cores:
0: 37 processors (0-36), Intel Darkmont
1: 1 processor (37), Intel Darkmont
2: 1 processor (38), Intel Darkmont

caveat - the package name is incorrect, but the error is in sde.
cpuid instruction reports that string, and comes from a text file that sde uses:
intelsde/misc/cpuid/cwf/cpuid.def

- Darkmont is the uarch used in Clearwater Forest
fbarchard added 3 commits May 30, 2025 12:10
- Darkmont is the uarch used in Clearwater Forest
- Darkmont is the uarch used in Clearwater Forest
Copy link
Contributor

@rrwinterton rrwinterton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm just a name change not a cpu id change fix

Copy link
Contributor

@rrwinterton rrwinterton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fbarchard
Copy link
Collaborator Author

its not a name change, its a new family/model/stepping for a cpu (clearwater forest) that has darkmont uarch
cpuinfo has a few other e-cores, typically used low end laptops

@kimishpatel kimishpatel merged commit bac1e85 into pytorch:main Jun 9, 2025
12 checks passed
@kimishpatel kimishpatel mentioned this pull request Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants