Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate prototype/quantized_training to configs #1855

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

Conversation

vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Mar 7, 2025

Summary:

As titled

Test Plan:

pytest test/prototype/test_quantized_training.py -s -x

Reviewers:

Subscribers:

Tasks:

Tags:

vkuzo added 5 commits March 7, 2025 06:48
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Copy link

pytorch-bot bot commented Mar 7, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1855

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit c038451 with merge base f64d5a1 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 7, 2025
vkuzo added a commit that referenced this pull request Mar 7, 2025
Summary:

As titled

Test Plan:

```
pytest test/prototype/test_quantized_training.py -s -x
```

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: e4b9e86338a0eeb36929555b4cf6a86adc5febf3
ghstack-comment-id: 2706898680
Pull Request resolved: #1855
@vkuzo
Copy link
Contributor Author

vkuzo commented Mar 7, 2025

cc @gau-nernst as a heads up

@vkuzo vkuzo added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Mar 7, 2025
[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Mar 7, 2025
Summary:

As titled

Test Plan:

```
pytest test/prototype/test_quantized_training.py -s -x
```

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 764c20e34c3dc23aae77397894cd7370f7d41865
ghstack-comment-id: 2706898680
Pull Request resolved: #1855
vkuzo added 3 commits March 7, 2025 09:51
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
vkuzo added 6 commits March 7, 2025 11:39
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
vkuzo added 4 commits March 7, 2025 12:47
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]


# for bc
bitnet_training = BitNetTrainingConfig
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto on bc break here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd actually prefer to keep it, see previous PR for some additional context

vkuzo added 15 commits March 8, 2025 06:15
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@vkuzo vkuzo changed the base branch from gh/vkuzo/58/head to main March 8, 2025 20:19
[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants