config migration: smoothquant #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1851
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 6f3d127 with merge base b6db962 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
vkuzo
added a commit
that referenced
this pull request
Mar 7, 2025
Summary: Migrates smoothquant to direct configs Test Plan: ``` pytest test/prototype/test_smoothquant.py -s -x ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 2d881f3403e8a45123bbb9de931f129c32bf89ee ghstack-comment-id: 2706636586 Pull Request resolved: #1851
facebook-github-bot
added
the
CLA Signed
vkuzo
added
the
topic: not user facing
This was referenced Mar 7, 2025
torchao/prototype/smoothquant/api.py
Outdated
| device=observed_linear.weight.device, | ||
| dtype=observed_linear.weight.dtype, | ||
| ) | ||
| # linear.weight = torch.nn.Parameter( |
There was a problem hiding this comment.
looks like this file contains various lines of commented out code, can we just delete it?
There was a problem hiding this comment.
sure, I'll delete it before landing
danielvegamyhre
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Migrates smoothquant to direct configs
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: