-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(headless): add ActionWaitDialog
type
#5545
feat(headless): add ActionWaitDialog
type
#5545
Conversation
ActionWaitDialog
type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, very nice work 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- panic upon CLT +C
$ echo http://honey.scanme.sh | ./nuclei -t test.yaml -headless
__ _
____ __ _______/ /__ (_)
/ __ \/ / / / ___/ / _ \/ /
/ / / / /_/ / /__/ / __/ /
/_/ /_/\__,_/\___/_/\___/_/ v3.3.1
projectdiscovery.io
[INF] Current nuclei version: v3.3.1 (outdated)
[INF] Current nuclei-templates version: v9.9.3 (latest)
[WRN] Scan results upload to cloud is disabled.
[INF] New templates added in latest release: 56
[INF] Templates loaded for current scan: 1
[WRN] Loading 1 unsigned templates for scan. Use with caution.
[INF] Targets loaded for current scan: 1
^C[INF] CTRL+C pressed: Exiting
[INF] Attempting graceful shutdown...
panic: interface conversion: interface {} is nil, not string
goroutine 27 [running]:
github.com/projectdiscovery/nuclei/v3/pkg/protocols/headless.(*Request).executeRequestWithPayloads(0x14000f6ae00, 0x140007f7230, 0x140015109a0?, 0x6?, 0x140008baaf8)
/Users/geekboy/Github/nuclei/pkg/protocols/headless/request.go:186 +0x12fc
github.com/projectdiscovery/nuclei/v3/pkg/protocols/headless.(*Request).ExecuteWithResults(0x14000f6ae00, 0x14000057248?, 0x140007f6b70, 0x100af5864?, 0x140007f7500)
/Users/geekboy/Github/nuclei/pkg/protocols/headless/request.go:87 +0x490
github.com/projectdiscovery/nuclei/v3/pkg/tmplexec/generic.(*Generic).ExecuteWithResults(0x14000958f90, 0x14000961680)
/Users/geekboy/Github/nuclei/pkg/tmplexec/generic/exec.go:61 +0x28c
github.com/projectdiscovery/nuclei/v3/pkg/tmplexec.(*TemplateExecuter).Execute(0x14000d11300, 0x14000961680)
/Users/geekboy/Github/nuclei/pkg/tmplexec/exec.go:199 +0x340
github.com/projectdiscovery/nuclei/v3/pkg/core.(*Engine).executeTemplateWithTargets.func2.1(0x14ec690?, 0x40?, 0x14000d11540)
/Users/geekboy/Github/nuclei/pkg/core/executors.go:139 +0x1b0
created by github.com/projectdiscovery/nuclei/v3/pkg/core.(*Engine).executeTemplateWithTargets.func2 in goroutine 26
/Users/geekboy/Github/nuclei/pkg/core/executors.go:115 +0x478
- disable cert validation in headless? not sure if we do this but I don't find results when running with
https://honey.scanme.sh
that has expired cert.
6ee5d39
to
d1d91d5
Compare
@ehsandeep - To your answer #5550 (comment) |
also implement it Signed-off-by: Dwi Siswanto <[email protected]>
Signed-off-by: Dwi Siswanto <[email protected]>
also: * expose `err` from \*proto.PageHandleJavaScriptDialog` * conditional ActionData assignment based on Signed-off-by: Dwi Siswanto <[email protected]>
Signed-off-by: Dwi Siswanto <[email protected]>
…esource` Signed-off-by: Dwi Siswanto <[email protected]>
Signed-off-by: Dwi Siswanto <[email protected]>
Signed-off-by: Dwi Siswanto <[email protected]>
to `header` & `status_code` Signed-off-by: Dwi Siswanto <[email protected]>
Signed-off-by: Dwi Siswanto <[email protected]>
This reverts commit fa12e0d.
d1d91d5
to
84e8573
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dwisiswant0 this will make things much easier!
we can also update the docs at - https://docs.projectdiscovery.io/templates/protocols/headless
Proposed changes
Close #5526
How has this been tested?
Proof
Checklist