Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dialog handler for headless protocol #5526

Closed
dwisiswant0 opened this issue Aug 16, 2024 · 0 comments · Fixed by #5545
Closed

Add dialog handler for headless protocol #5526

dwisiswant0 opened this issue Aug 16, 2024 · 0 comments · Fixed by #5545
Assignees
Labels
Type: Enhancement Most issues will probably ask for additions or changes.
Milestone

Comments

@dwisiswant0
Copy link
Member

I've been bugged for ages by how the engine handles XSS payload detection. It’s such a pain having to add specific matchers for each server or target technology.

A recent discussion1 brought back all those annoying memories. I get that it’s all about improving accuracy and avoiding false positives, which I completely understand, but it makes things way more complicated than they23 need to be.

Since the engine supports headless browsers, I think we have a chance to fix this. By using headless browsers, we can avoid increasing the workload4 for users.

I was looking through the rod docs and found that it has a *Page.HandleDialog method that looks perfect for this. This method can accurately detect if an XSS payload is triggered, giving us consistent true positives.

Integrating this method into the engine could make things a lot easier for users. We'd no longer need to mess around with those unique matchers, and we'd still maintain the high level of accuracy needed for detecting XSS payloads. This change would make the engine much more efficient, which would be a huge win for everyone.

Footnotes

  1. https://github.com/projectdiscovery/nuclei-templates/discussions/10529

  2. http/cves/2022/CVE-2022-26263.yaml template.

  3. headless/cves/2018/CVE-2018-25031.yaml template.

  4. Researching the target through Shodan or even setting up a vulnerable lab environment — just to see what's unique inside it. 😒

@dwisiswant0 dwisiswant0 added the Type: Enhancement Most issues will probably ask for additions or changes. label Aug 16, 2024
@dwisiswant0 dwisiswant0 self-assigned this Aug 16, 2024
@ehsandeep ehsandeep added this to the nuclei v3.3.2 milestone Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants