-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lakes and rivers geometry on scoped geo subplots #4048
Conversation
cc @plotly/plotly_js don't attempt to update https://codepen.io/nicolaskruchten/pen/orRBKb?editors=0010 from #4046 to see the new behaviour. We need to first update https://cdn.plot.ly/africa_110m.json and friends. |
You'll notice that |
@@ -0,0 +1,264 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is rather difficult to view & compare the before/after images (with aspect-ratio close to 2) on small monitors. @etpinard would you mind splitting the mock into two mocks? |
@archmoj does this help? |
@etpinard I cannot |
Thank you @etpinard for the update and the mock 💃 |
Is @archmoj ok also with the changes? Here's the script I used to generate the new mock: var schema = Plotly.PlotSchema.get()
var scopes = schema.layout.layoutAttributes.geo.scope.values
var resolutions = [110, 50]
var traces = []
var layout = {
grid: {rows: scopes.length, columns: resolutions.length},
width: 600,
height: 1500
}
var k = 0
resolutions.forEach((r, i) => {
scopes.forEach((s, j) => {
var id = 'geo' + (k ? (k + 1) : '')
traces.push({type: 'scattergeo', geo: id})
layout[id] = {
scope: s,
resolution: r,
domain: {column: i, row: j},
landcolor: "brown",
showland: true,
lakecolor: "blue",
showlakes: true,
rivercolor: "blue",
showrivers: true
}
k++
})
})
Plotly.newPlot(gd, traces, layout, {scrollZoom:false}) It should be easy to transpose (i,j) -> (j,i), if that makes it easier to review for you. |
💃 |
fixes #4046 (a regression from #3856) with the help of etpinard/sane-topojson#14