Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Countries missing in scope=africa #4046

Closed
nicolaskruchten opened this issue Jul 14, 2019 · 4 comments · Fixed by #4048
Closed

Countries missing in scope=africa #4046

nicolaskruchten opened this issue Jul 14, 2019 · 4 comments · Fixed by #4048
Assignees
Labels
bug something broken

Comments

@nicolaskruchten
Copy link
Contributor

In this plot https://plot.ly/~nicolaskruchten/364 countries like Congo are white/missing but are highlighted in scope=world mode.

@nicolaskruchten
Copy link
Contributor Author

Ah I found the problem: it's lakes! https://codepen.io/nicolaskruchten/pen/orRBKb?editors=0010

@etpinard
Copy link
Contributor

Thanks for spotting that!

There must be a broken polygon in https://cdn.plot.ly/africa_110m.json and even in https://cdn.plot.ly/africa_50m.json (example https://codepen.io/etpinard/pen/YooNEm?editors=0010)

@etpinard etpinard added the bug something broken label Jul 15, 2019
@etpinard etpinard self-assigned this Jul 15, 2019
@nicolaskruchten
Copy link
Contributor Author

nicolaskruchten commented Jul 15, 2019

This normally wouldn't show up so obviously but the new default Plotly template (in Chart Studio and Plotly.py) sets the lake color to white :)

@nicolaskruchten
Copy link
Contributor Author

I would suggest adding a mock which contains one of each scope we have, with the various show* = true and *color=<unique>, so that we can more easily track regressions, and/or spot check for other such issues in the current set of polygons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants