Skip to content

Isosurface opacity #3545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 18, 2019
+6,515 −108
Merged

Isosurface opacity #3545

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c378c36
adding opacity to isosurface
archmoj Feb 14, 2019
678c47a
transparent isosurface mock
archmoj Feb 14, 2019
b94dcce
baseline highlights double draws close to the edges
archmoj Feb 14, 2019
baa0eb6
avoid duplicate draws close to the edges of caps and slices
archmoj Feb 14, 2019
95d4ba7
correct baseline using new algorithm
archmoj Feb 14, 2019
3ec6bc6
reduced acceptable error fixes glitch in gl3d_isosurface_xycaps_volum…
archmoj Feb 14, 2019
4d922a7
corrected baseline with less error
archmoj Feb 14, 2019
e586fb0
fix thin edges - sharp slices
archmoj Feb 15, 2019
f37520a
new transparent baseline with sharper caps and slices
archmoj Feb 15, 2019
15a1578
needed to add tiny error to force solve tiny caps
archmoj Feb 15, 2019
d73030c
correct baseline and added new mock to lock the issue with tiny slices
archmoj Feb 15, 2019
12df469
new baseline to lock the bug for tiny slices
archmoj Feb 15, 2019
abc8ae2
edited the description of surface opacity attribute
archmoj Feb 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/traces/isosurface/attributes.js
View file
Original file line number Diff line number Diff line change
@@ -235,10 +235,11 @@ colorscaleAttrs('', {

colorbar: colorbarAttrs,

contour: meshAttrs.contour,
opacity: meshAttrs.opacity,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably point out in the mesh3d attributes that the current behavior isn't perfect and may be subject to change in the (near) future cc #3243

lightposition: meshAttrs.lightposition,
lighting: meshAttrs.lighting,
flatshading: meshAttrs.flatshading,
contour: meshAttrs.contour,

hoverinfo: extendFlat({}, baseAttrs.hoverinfo)
}), 'calc', 'nested');
Loading