Isosurface opacity #3545
Merged
Isosurface opacity #3545
+6,515
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archmoj
added
feature
|
@archmoj Is this one ready to review? |
etpinard
reviewed
Feb 15, 2019
| @@ -235,10 +235,11 @@ colorscaleAttrs('', { | |||
|
|
|||
| colorbar: colorbarAttrs, | |||
|
|
|||
| contour: meshAttrs.contour, | |||
| opacity: meshAttrs.opacity, | |||
There was a problem hiding this comment.
We should probably point out in the mesh3d attributes that the current behavior isn't perfect and may be subject to change in the (near) future cc #3243
|
Looks good! #3545 (comment) is my only comment. |
@etpinard Thanks for the review. |
|
Thanks @archmoj ! 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables
opacityattribute forisosurfacetraces.Also it addressed bug #3546 and removed the second drawings to find the edges see here.
In addition some improvements such as reduction of tolerance (to remove glitch in mesh generation #3547) are made in this PR. Various functions now return
trueorfalseresult in case triangles are generated. This information is stored in the first pass & could be used in second pass processes.This PR would be helpful for the
volumePR #3488.@plotly/plotly_js
Before codepen.
After codepen.