Candlestick hover label fix #2264
Merged
+20
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // don't show labels in candlestick hover labels | ||
| if(trace._fullInput && trace._fullInput.type === 'candlestick') { | ||
| delete cd[0].t.labels; | ||
| } |
There was a problem hiding this comment.
not a big deal, but 🐎 I might invert this logic and only add labels if we do want them.
There was a problem hiding this comment.
I thought about that. But, I prefer writing candlestick-only blocks like this one as exceptions to a rule (the rule here being fill up cd[0].t.labels). Here's another example.
I can't wait to rewrite candlestick and ohlc as good old (non-transform) trace types 🙃
There was a problem hiding this comment.
I prefer writing candlestick-only blocks like this one as exceptions to a rule
Good point.
|
nonblocking #2264 (comment), looks great 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2253
cc @alexcjohnson