Merge pull request #2264 from plotly/candlestick-hover-label-regression

Candlestick hover label fix

Author: etpinard

src/traces/box/calc.js

@@ -136,6 +136,11 @@ module.exports = function calc(gd, trace) {
             }
         };
 
+        // don't show labels in candlestick hover labels
+        if(trace._fullInput && trace._fullInput.type === 'candlestick') {
+            delete cd[0].t.labels;
+        }
+
         fullLayout[numKey]++;
         return cd;
     } else {

src/traces/box/hover.js

@@ -159,7 +159,7 @@ function hoverOnBoxes(pointData, xval, yval, hovermode) {
 
         pointData2[vLetter + '0'] = pointData2[vLetter + '1'] = valPx;
         pointData2[vLetter + 'LabelVal'] = val;
-        pointData2[vLetter + 'Label'] = t.labels[attr] + ' ' + Axes.hoverLabelText(vAxis, val);
+        pointData2[vLetter + 'Label'] = (t.labels ? t.labels[attr] + ' ' : '') + Axes.hoverLabelText(vAxis, val);
 
         if(attr === 'mean' && ('sd' in di) && trace.boxmean === 'sd') {
             pointData2[vLetter + 'err'] = di.sd;

test/jasmine/tests/finance_test.js

@@ -384,16 +384,19 @@ describe('finance charts calc transforms:', function() {
         return calcTrace[0].trace;
     }
 
-    function _calc(data, layout) {
+    function _calcRaw(data, layout) {
         var gd = {
             data: data,
             layout: layout || {}
         };
 
         supplyAllDefaults(gd);
         Plots.doCalcdata(gd);
+        return gd.calcdata;
+    }
 
-        return gd.calcdata.map(calcDatatoTrace);
+    function _calc(data, layout) {
+        return _calcRaw(data, layout).map(calcDatatoTrace);
     }
 
     // add some points that shouldn't make it into calcdata because
@@ -758,6 +761,15 @@ describe('finance charts calc transforms:', function() {
             2, 2, 2, 2, 2, 2
         ]);
     });
+
+    it('should not include box hover labels prefix in candlestick calcdata', function() {
+        var trace0 = Lib.extendDeep({}, mock0, {
+            type: 'candlestick',
+        });
+        var out = _calcRaw([trace0]);
+
+        expect(out[0][0].t.labels).toBeUndefined();
+    });
 });
 
 describe('finance charts updates:', function() {