Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1328 skip translatePoint for empty nodes #1336

Merged
merged 1 commit into from
Feb 2, 2017
Merged

Fix #1328 skip translatePoint for empty nodes #1336

merged 1 commit into from
Feb 2, 2017
+23 −1

Conversation

inDream
Copy link
Contributor

@inDream inDream commented Jan 26, 2017

Fix #1328

@etpinard
Copy link
Contributor

@inDream looks good. Big thanks!

Before merging this in, we'll need to add a test case. Would you interested in doing so?

I was able to reproduce this bug using Plotly.relayout (see https://jsfiddle.net/6L8nLgr1/2/) which will make adding the test case a lot easier.

@etpinard etpinard added status: in progress bug something broken labels Jan 30, 2017
@inDream
Copy link
Contributor Author

inDream commented Feb 2, 2017

@etpinard I've added test but don't know whether is it the correct location.

@etpinard
Copy link
Contributor

etpinard commented Feb 2, 2017

Looking great @inDream

Thanks very much for doing this. I can't think of a better place to put this test case. Great job 🍻

@etpinard etpinard added this to the 1.23.0 milestone Feb 2, 2017
@etpinard etpinard merged commit 49f2137 into plotly:master Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@inDream @etpinard