Skip to content

Error when pan scatter with empty text #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
inDream opened this issue Jan 24, 2017 · 1 comment
Closed

Error when pan scatter with empty text #1328

inDream opened this issue Jan 24, 2017 · 1 comment
Labels
bug something broken

Comments

@inDream
Copy link
Contributor

inDream commented Jan 24, 2017

Change https://github.com/plotly/plotly.js/blob/master/src/components/drawing/index.js#L54
from if(isNumeric(x) && isNumeric(y)) { to if(isNumeric(x) && isNumeric(y) && sel.node()) {
solved this problem.

Demo: https://jsfiddle.net/indream/6L8nLgr1/

@rreusser
Copy link
Contributor

rreusser commented Jan 24, 2017

Thanks so much for the report and for tracking this down! That makes pretty good sense. Would you be willing to make a PR for this? This might be small and straightforward enough that it doesn't require a specific test (debatably), but it's still necessary to ensure the tests as a whole are fine. The basic process is:

  1. fork the repo
  2. make the fix
  3. run npm run lint-fix, commit, and push to your branch
  4. file a PR

That would be greatly appreciated but no pressure. If not I'll try to get a PR together for it. Thanks again!

inDream added a commit to inDream/plotly.js that referenced this issue Jan 26, 2017
@etpinard etpinard added the bug something broken label Jan 30, 2017
inDream added a commit to inDream/plotly.js that referenced this issue Feb 2, 2017
etpinard added a commit that referenced this issue Feb 2, 2017
Fix #1328 skip translatePoint for empty nodes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

No branches or pull requests

3 participants