Do not create default sync root when loading accounts #11128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOneRing
approved these changes
Aug 18, 2023
TheOneRing
reviewed
Aug 18, 2023
|
I opened an issue for the crash in the gui test. |
TheOneRing
suggested changes
Aug 22, 2023
Creating the default sync root is only needed at initial setup. If a user chooses to point all folders for Spaces outside that default sync root, and deletes the default sync root folder, it should not be re-created. Fixes: #10919
erikjv
force-pushed
the
work/do-not-recreate-deleted-sync-root
branch
from
09ce8c6 to
f0fd29d
Compare
|
Kudos, SonarCloud Quality Gate passed! |
TheOneRing
approved these changes
Aug 24, 2023
delete-merged-branch
bot
deleted the
work/do-not-recreate-deleted-sync-root
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating the default sync root is only needed at initial setup. If a user chooses to point all folders for Spaces outside that default sync root, and deletes the default sync root folder, it should not be re-created.
Fixes: #10919