Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default sync root directory created every time accounts are loaded #10919

Closed
2 tasks done
fmoc opened this issue Jun 13, 2023 · 4 comments · Fixed by #11128
Closed
2 tasks done

Default sync root directory created every time accounts are loaded #10919

fmoc opened this issue Jun 13, 2023 · 4 comments · Fixed by #11128
Assignees
@erikjv
Labels
p4-low Low priority type:bug
Milestone
Desktop 5.0

Comments

@fmoc
Copy link
Contributor

fmoc commented Jun 13, 2023

Pre-submission Checks

  • I checked for similar issues, but could not find any. I also checked the closed issues. I could not contribute additional information to any existing issue.
  • I will take the time to fill in all the required fields. I know that the bug report may be dismissed otherwise due to lack of information.

Describe the bug

See https://central.owncloud.org/t/default-folder-created-at-each-start/44101.

The default sync root directory is created over and over again if set.

Expected behavior

It makes no sense to create the directory every time. Users may not even use it at all but use a totally different base directory to synchronize their files.

Possible solutions:

  • create sync root directory only once after the wizard finishes (if synchronization is to be configured with the folder wizard)
  • just don't create it unless explicitly required

I am in favor with the latter.

Steps to reproduce the issue

No response

Screenshots

No response

Logs

No response

Client version number

4.0.0.10896 on Ubuntu 22.04.

Desktop environment (Linux only)

No response

Client package version and origin (Linux only)

No response

Installation path (Windows only)

No response

Server information

No response

Additional context

No response
@fmoc fmoc added the type:bug label Jun 13, 2023
@michaelstingl michaelstingl added this to the inbox milestone Jun 15, 2023
@TheOneRing TheOneRing added the p4-low Low priority label Jun 16, 2023
@TheOneRing TheOneRing modified the milestones: inbox, Desktop Client 5.0 Jun 16, 2023
erikjv added a commit that referenced this issue Aug 17, 2023
@erikjv
Do not create default sync root when loading accounts
09ce8c6 
Creating the default sync root is only needed at initial setup. If a
user chooses to point all folders for Spaces outside that default sync
root, and deletes the default sync root folder, it should not be
re-created.

Fixes: #10919
@erikjv erikjv mentioned this issue Aug 17, 2023
Merged
erikjv added a commit that referenced this issue Aug 23, 2023
@erikjv
Do not create default sync root when loading accounts
f0fd29d 
Creating the default sync root is only needed at initial setup. If a
user chooses to point all folders for Spaces outside that default sync
root, and deletes the default sync root folder, it should not be
re-created.

Fixes: #10919
erikjv added a commit that referenced this issue Aug 24, 2023
@erikjv
Do not create default sync root when loading accounts
493d87b 
Creating the default sync root is only needed at initial setup. If a
user chooses to point all folders for Spaces outside that default sync
root, and deletes the default sync root folder, it should not be
re-created.

Fixes: #10919
@HanaGemela
Copy link
Contributor

@fmoc could you specify the steps to recreate?
I've tried with 4.0.0 and Ubuntu 22.04

  1. Add a new account
  2. Log out
  3. Log back in
  4. Check the file explorer -> Just one owncloud folder

@fmoc
Copy link
Contributor Author

fmoc commented Aug 30, 2023 •
edited
Loading

Use case 1:

  1. Add new account regularly
  2. Add a second sync root (with some different path)
  3. Remove original sync root (with the default location)
  4. Close client
  5. Remove directory in default location
  6. Start client again (this loads the accounts again)
  7. Check if the default location was created again

@fmoc
Copy link
Contributor Author

fmoc commented Aug 30, 2023 •
edited
Loading

Use case 2:

  1. Add new account with a non-default sync root path (i.e., change the path on the last setup wizard page)
  2. Add a second sync root (with some different path)
  3. Remove first sync root
  4. Close client
  5. Remove directory in the first location you set in the account setup wizard
  6. Start client again (this loads the accounts again)
  7. Check if a directory in the first location was created again

It's really a minor bug, but it deserved a fix.

@HanaGemela
Copy link
Contributor

Passed in owncloud-client_5.0.0.11978-daily20230830

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikjv erikjv

Labels
p4-low Low priority type:bug
Projects
None yet
Milestone
Desktop 5.0
Development

Successfully merging a pull request may close this issue.

Do not create default sync root when loading accounts owncloud/client
5 participants
@erikjv @TheOneRing @michaelstingl @HanaGemela @fmoc