Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win7, client 2.5.0, replacing more than 47 files at a time by virtual files impossible #6780

Closed
sorenweber opened this issue Sep 19, 2018 · 5 comments
Assignees
Labels
ReadyToTest QA, please validate the fix/enhancement
Milestone

Comments

@sorenweber
Copy link

sorenweber commented Sep 19, 2018

Expected behaviour

I select 48 files (jpeg-photos) or more, right-click and select ownCloud->Replace file(s) by virtual file, and the files will be replaced by virtual files.

Actual behaviour

If I select 48 files or more, nothing happens. If I select 47 files or less, it works.

Steps to reproduce

  1. Select 48 files or more in Windows Explorer
  2. Right-click and select ownCloud->Replace file(s) by virtual file
  3. Observe that nothing happens

Server configuration

Operating system: Windows 7 Enterprise 64-bit

Web server: Apache 2.4

Database: MySQL

PHP version: 7.0

ownCloud version: 10.0.9

Storage backend (external storage):

Client configuration

Client version: 2.5.0

Operating system: Windows 7 Enterprise

OS language: US

Qt version used by client package (Linux only, see also Settings dialog):

Client package (From ownCloud or distro) (Linux only):

Installation path of client:

Logs

Please use Gist (https://gist.github.com/) or a similar code paster for longer
logs.

Template for output < 10 lines

  1. Client logfile: Output of owncloud --logwindow or owncloud --logfile log.txt
    (On Windows using cmd.exe, you might need to first cd into the ownCloud directory)
    (See also http://doc.owncloud.org/desktop/2.2/troubleshooting.html#client-logfile )

  2. Web server error log:

  3. Server logfile: ownCloud log (data/owncloud.log):

@ogoffart
Copy link
Contributor

I just realize there is a 4K buffer that need to contains the concatenation of all the filename.
So if all the file names is bigger than about 4000 character, this won't work.

@ogoffart ogoffart self-assigned this Sep 20, 2018
ogoffart added a commit that referenced this issue Sep 20, 2018
Otherwise we can't have operation that has many many filename

As reported in #6780
@ogoffart ogoffart added this to the 2.5.1 milestone Sep 20, 2018
@ogoffart
Copy link
Contributor

Should be fixed with #6782 , thanks for the bug report!

ogoffart added a commit that referenced this issue Sep 21, 2018
Otherwise we can't have operation that has many many filename

As reported in #6780
@sorenweber
Copy link
Author

Should be fixed with #6782 , thanks for the bug report!

Awesome, thanks for fixing it!

@ogoffart ogoffart added the ReadyToTest QA, please validate the fix/enhancement label Sep 26, 2018
@guruz
Copy link
Contributor

guruz commented Oct 13, 2018

@sorenweber Can you verify the fix using a 2.5.1 daily build? Thank you
https://download.owncloud.com/desktop/daily/ownCloud-2.5.1.10806.10727-daily20181013.msi

@sorenweber
Copy link
Author

I have verified the fix, and it works (both ways, i.e. replacing files with virtual files, and vice versa). I had to perform the recommended reboot after installation. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReadyToTest QA, please validate the fix/enhancement
Projects
None yet
Development

No branches or pull requests

3 participants