Windows Shell Integration: Don't limit the size of the buffer

ogoffart · ogoffart · commit e04af3088bb1 · 2018-09-21T11:50:23.000+02:00
Otherwise we can't have operation that has many many filename As reported in #6780
diff --git a/shell_integration/windows/OCContextMenu/OCClientInterface.cpp b/shell_integration/windows/OCContextMenu/OCClientInterface.cpp
@@ -32,7 +32,6 @@
 using namespace std;
 
 #define PIPE_TIMEOUT  5*1000 //ms
-#define SOCK_BUFFER 4096
 
 OCClientInterface::ContextMenuInfo OCClientInterface::FetchInfo(const std::wstring &files)
 {
@@ -92,9 +91,5 @@ void OCClientInterface::SendRequest(const wchar_t *verb, const std::wstring &pat
         return;
     }
 
-    wchar_t msg[SOCK_BUFFER] = { 0 };
-    if (SUCCEEDED(StringCchPrintf(msg, SOCK_BUFFER, L"%s:%s\n", verb, path.c_str())))
-    {
-        socket.SendMsg(msg);
-    }
+    socket.SendMsg((verb + (L":" + path + L"\n")).data());
 }

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,6 @@`
`32`	`32`	`using namespace std;`
`33`	`33`
`34`	`34`	`#define PIPE_TIMEOUT 5*1000 //ms`
`35`		`-#define SOCK_BUFFER 4096`
`36`	`35`
`37`	`36`	`OCClientInterface::ContextMenuInfo OCClientInterface::FetchInfo(const std::wstring &files)`
`38`	`37`	`{`
`@@ -92,9 +91,5 @@ void OCClientInterface::SendRequest(const wchar_t *verb, const std::wstring &pat`
`92`	`91`	`return;`
`93`	`92`	`}`
`94`	`93`
`95`		`- wchar_t msg[SOCK_BUFFER] = { 0 };`
`96`		`- if (SUCCEEDED(StringCchPrintf(msg, SOCK_BUFFER, L"%s:%s\n", verb, path.c_str())))`
`97`		`- {`
`98`		`- socket.SendMsg(msg);`
`99`		`- }`
	`94`	`+ socket.SendMsg((verb + (L":" + path + L"\n")).data());`
`100`	`95`	`}`