-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added patreon oidc provider #3021
Conversation
Edit: Merging master in fixed the test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this looks very good 👍
I just have one minor remark.
Codecov Report
@@ Coverage Diff @@
## master #3021 +/- ##
==========================================
- Coverage 77.41% 77.29% -0.12%
==========================================
Files 310 311 +1
Lines 19268 19317 +49
==========================================
+ Hits 14916 14932 +16
- Misses 3198 3234 +36
+ Partials 1154 1151 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Hello @AUSBird |
This PR is intending to implement another OIDC provider for Patreon to Kratos since Patreon has non-standard paths to it's
auth
andtoken
endpoints and doesn't have a discovery endpointWhile I was there I also added missing OIDC provider types to a code comment to update it with missing ones (Not sure if it matters or no)
Related issue(s)
I never made an issue to for this because it's just a new provider and the issue templates only has one for non-trivial features. (If I should have made one anyway, tell me for next time :) )
I did bring it up months ago in slack but never got any response,
PR for Documentation: ory/docs#1211
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments
This is my first ever go at golang so feel free to give me feedback on anything but I do ask you simplify a bit and if possible can I get pointers to documentation when comments are made to help me learn :)