Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added documentation for the patreon oauth provider #1211

Merged
merged 13 commits into from
Feb 9, 2023

Conversation

AUSBird
Copy link
Contributor

@AUSBird AUSBird commented Jan 13, 2023

Added documentation for a PR that adds a patreon OIDC provider

Related Issue or Design Document

PR for that added the patreon oidc provider to Kratos
ory/kratos#3021

There is no issue on the documentation repository

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

None

@AUSBird AUSBird changed the title docs: Added documentation for the Patreon oauth provider docs: added documentation for the patreon oauth provider Jan 13, 2023
Co-authored-by: Tom Papiernik <[email protected]>
@AUSBird
Copy link
Contributor Author

AUSBird commented Jan 29, 2023

Apologies for not fixing this up sooner. I will make the requested changes tonight after work.

@tomekpapiernik
Copy link
Contributor

@AUSBird that's okay! Please update the way you list claims, cut down on the number of scopes in the config snippet and use a plain link in the snippet instead of a hyperlink and we should be good to merge.

@AUSBird
Copy link
Contributor Author

AUSBird commented Feb 5, 2023

@tomekpapiernik I have made the changes. I swapped the claim list into a list that doesn't add long descriptions to each claim (That said they are kind of obvious what they do) two claims have a slash cause they are the same. And I removed all but two scopes in the config example with a link to the docs with the rest of the scopes.

Copy link
Contributor

@tomekpapiernik tomekpapiernik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🎉 I've applied minor cosmetic tweaks myself to speed things up. Merging once all tests pass. Cheers!

@AUSBird
Copy link
Contributor Author

AUSBird commented Feb 8, 2023

Cheers, thanks for the help :)

@tomekpapiernik tomekpapiernik merged commit 296a597 into ory:master Feb 9, 2023
@AUSBird AUSBird deleted the patreon-oidc branch February 12, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants