Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix part of #973 : Fix app module tests for Roboelectric in PinPasswordActivityTest #1854

Merged
merged 2 commits into from
Sep 18, 2020
Merged

Fix part of #973 : Fix app module tests for Roboelectric in PinPasswordActivityTest #1854

merged 2 commits into from
Sep 18, 2020

Conversation

anandwana001
Copy link
Contributor

@anandwana001 anandwana001 commented Sep 17, 2020 •
edited
Loading

Explanation

Fix part of #973
Fix for PinPasswordActivityTest

Espresso

Screenshot 2020-09-17 at 18 59 41

Robolectric

Screenshot 2020-09-17 at 18 54 37

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@anandwana001 anandwana001 requested a review from rt4914 September 17, 2020 13:33
aggarwalpulkit596
aggarwalpulkit596 reviewed Sep 18, 2020
View reviewed changes
app/src/sharedTest/java/org/oppia/app/profile/PinPasswordActivityTest.kt
override fun perform(uiController: UiController?, view: View?) {
// Appending text only works on Robolectric, whereas Espresso needs to use typeText().
if (Build.FINGERPRINT.contains("robolectric", ignoreCase = true)) {
(view as? EditText)?.append(text)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this indentation looks incorrect to me?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, I guess. I had already done the reformat thing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay thanks

aggarwalpulkit596
aggarwalpulkit596 approved these changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@aggarwalpulkit596 aggarwalpulkit596 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aggarwalpulkit596 aggarwalpulkit596 merged commit cb45e45 into oppia:develop Sep 18, 2020
prayutsu pushed a commit to prayutsu/oppia-android that referenced this pull request Sep 21, 2020
@anandwana001 @prayutsu
Fix part of oppia#973 : Fix app module tests for Roboelectric in PinP…
dffd343 
…asswordActivityTest (oppia#1854)

* fix PinPasswordActivityTest for robolectric

* added todo
prayutsu pushed a commit to prayutsu/oppia-android that referenced this pull request Sep 25, 2020
@anandwana001 @prayutsu
Fix part of oppia#973 : Fix app module tests for Roboelectric in PinP…
bbfa27a 
…asswordActivityTest (oppia#1854)

* fix PinPasswordActivityTest for robolectric

* added todo
@anandwana001 anandwana001 mentioned this pull request Dec 14, 2020
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aggarwalpulkit596 aggarwalpulkit596 aggarwalpulkit596 approved these changes

@rt4914 rt4914 Awaiting requested review from rt4914

Assignees

@rt4914 rt4914

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anandwana001 @aggarwalpulkit596 @rt4914