Fix app module tests for Roboelectric

[rt4914]

Currently, the app module test cases are passing on Espresso but they should also pass on Robolectric. Fix these below mentioned files to make sure that the tests pass on Robolectric.

You can run robolectric tests by following these steps: https://github.com/oppia/oppia-android/wiki/Oppia-Android-Testing#running-roboelectric-tests

Also, make sure that you assign yourself one task only at a time, which you can mention in the comments below.

Fixing test cases will need to introduce TextApplicationComponent. This can be seen here.

• AppVersionActivityTest (Assigned to @anandwana001 )
• CompletedStoryListActivityTest (Assigned to @anandwana001 )
• FAQListFragmentTest (Assigned to @Sarthak2601 )
• FAQSingleActivityTest (Assigned to @SayantanBanerjee16 )
• HelpFragmentTest (Assigned to @SayantanBanerjee16 )
• MyDownloadsFragmentTest(Assigned to @anandwana001 )
• HtmlParserTest (Assigned to @anandwana001 )
• StateFragmentTest (Fixed in Fix part of #973: Stabilize state fragment tests #1630)
• AddProfileActivityTest (Assigned to @anandwana001 )
• AdminAuthActivityTest (Assigned to @anandwana001 )
• AdminPinActivityTest (Assigned to @anandwana001 )
• ProfilePictureActivityTest(Assigned to @anandwana001 )
• ProfileProgressFragmentTest (Assigned to @veena14cs )
• BindableAdapterTest (Assigned to @anandwana001 )
• SplashActivityTest (Fixed in Fix #1298: Introduce app auto expiration #1397)
• StoryActivityTest (Assigned to @anandwana001 )
• StoryFragmentTest (Assigned to @anandwana001 )
• QuestionPlayerActivityTest (Assigned to @anandwana001)
• TopicTestActivityForStoryTest(Assigned to @anandwana001 )
• RevisionCardFragmentTest (Assigned to @anandwana001 )
• WalkthroughWelcomeFragmentTest(Assigned to @veena14cs )
• WalkthroughTopicListFragmentTest(Assigned to @anandwana001 )
• WalkthroughFinalFragmentTest (Assigned to @anandwana001 )
• WalkthroughActivityTest(Assigned to @anandwana001 )

[abhinavraj23]

@rt4914 please assign me one of these tasks.

[SayantanBanerjee16]

@rt4914 Can you assign me some of this task. Also, this task means that we would be running the previously written tests in Roboelectric, or writing new tests based on previous tests?

[rt4914]

@rt4914 Can you assign me some of this task. Also, this task means that we would be running the previously written tests in Roboelectric, or writing new tests based on previous tests?

You can just run the previously written test cases in Roboelectic and which every test fails, fix them and make sure that it passes on Espresso as well as Roboelectric

[SayantanBanerjee16]

@rt4914 So I followed the steps given in the link above and all the tests in AppVersionActivityTest.kt passed. Now can you please assign me files 4,5,6 in the list above. Thanks :)

[virajpatel2411]

@rt4914 Assign me any one of these tasks. Thanks.

[SayantanBanerjee16]

@rt4914 FAQSingleActivityTest Roboelectric tests passed.
I am assigning myself the next two files in the list.

[virajpatel2411]

@rt4914 In CompletedStoryListActivityTest, 8 out of 9 tests are failing for Roboelectric and all of then are passing in Espresso. The failed tests show the error of PerformException, so maybe there seems to be an issue with the perform() method. So, what do you suggest to change, because I am not getting what is wrong with the method if all the tests are passing for Espresso.

[abhinavraj23]

@rt4914 for the tests concerning dialog-box opening or navigation-bar opening, it would not work with roboelectric in the same way as it works in espresso, thus for these we may need to write separate tests, I have been able to successfully write tests for dialogBoxes in roboelectric but those don't work in espresso, thus we may need to write separately for these tests

[Sarthak2601]

All Robolectric tests pass in FAQListFragmentTest

[rt4914]

@rt4914 for the tests concerning dialog-box opening or navigation-bar opening, it would not work with roboelectric in the same way as it works in espresso, thus for these we may need to write separate tests, I have been able to successfully write tests for dialogBoxes in roboelectric but those don't work in espresso, thus we may need to write separately for these tests

@abhinavraj23 Its write to add new test cases as per requirement but each and every test case should pass on both espresso and roboelectric. So you can just create a PR and we can figure out from that.

[rt4914]

@rt4914 In CompletedStoryListActivityTest, 8 out of 9 tests are failing for Roboelectric and all of then are passing in Espresso. The failed tests show the error of PerformException, so maybe there seems to be an issue with the perform() method. So, what do you suggest to change, because I am not getting what is wrong with the method if all the tests are passing for Espresso.

@virajpatel2411 It can happen that tests pass on espresso and fails on roboelectic and that's why we have this issue to track everything. Have you tried searching for solutions for those errors on internet?

[virajpatel2411]

@rt4914 In CompletedStoryListActivityTest, 8 out of 9 tests are failing for Roboelectric and all of then are passing in Espresso. The failed tests show the error of PerformException, so maybe there seems to be an issue with the perform() method. So, what do you suggest to change, because I am not getting what is wrong with the method if all the tests are passing for Espresso.

@virajpatel2411 It can happen that tests pass on espresso and fails on roboelectic and that's why we have this issue to track everything. Have you tried searching for solutions for those errors on internet?

Yes, but I didn't find anything helpful. Imk, there resides some issue with perform() method as in every test case in Roboelectric the PerformException is thrown. Now, what should I do?

[rt4914]

@rt4914 In CompletedStoryListActivityTest, 8 out of 9 tests are failing for Roboelectric and all of then are passing in Espresso. The failed tests show the error of PerformException, so maybe there seems to be an issue with the perform() method. So, what do you suggest to change, because I am not getting what is wrong with the method if all the tests are passing for Espresso.

@virajpatel2411 It can happen that tests pass on espresso and fails on roboelectic and that's why we have this issue to track everything. Have you tried searching for solutions for those errors on internet?

Yes, but I didn't find anything helpful. Imk, there resides some issue with perform() method as in every test case in Roboelectric the PerformException is thrown. Now, what should I do?

@virajpatel2411 You can either prepare a document of what all things you have tried and the errors you have faced so that we can have a look.
2. You can pick a new issue to work on from this list.

But the main point is that you will need to give information in detail so that we can have a look at the problem.

[virajpatel2411]

@rt4914 In CompletedStoryListActivityTest, 8 out of 9 tests are failing for Roboelectric and all of then are passing in Espresso. The failed tests show the error of PerformException, so maybe there seems to be an issue with the perform() method. So, what do you suggest to change, because I am not getting what is wrong with the method if all the tests are passing for Espresso.

@virajpatel2411 It can happen that tests pass on espresso and fails on roboelectic and that's why we have this issue to track everything. Have you tried searching for solutions for those errors on internet?

Yes, but I didn't find anything helpful. Imk, there resides some issue with perform() method as in every test case in Roboelectric the PerformException is thrown. Now, what should I do?

@virajpatel2411 You can either prepare a document of what all things you have tried and the errors you have faced so that we can have a look.
2. You can pick a new issue to work on from this list.

But the main point is that you will need to give information in detail so that we can have a look at the problem.

Okay...Will share the details once I have prepared it. Thanks.

[virajpatel2411]

@rt4914 https://docs.google.com/document/d/12vTSL8eW9LMtPmxSGFnWvmQfJumJ4BOdBduqeUm8vmw/edit?usp=sharing.
This is the link of the document I prepared. Hope it helps you understand the problem faced.

[virajpatel2411]

@rt4914 https://docs.google.com/document/d/12vTSL8eW9LMtPmxSGFnWvmQfJumJ4BOdBduqeUm8vmw/edit?usp=sharing.
This is the link of the document I prepared. Hope it helps you understand the problem faced.

@rt4914 Any updates for further work?

[rt4914]

@rt4914 https://docs.google.com/document/d/12vTSL8eW9LMtPmxSGFnWvmQfJumJ4BOdBduqeUm8vmw/edit?usp=sharing.
This is the link of the document I prepared. Hope it helps you understand the problem faced.

@veena14cs PTAL at this issue.

[virajpatel2411]

@rt4914 https://docs.google.com/document/d/12vTSL8eW9LMtPmxSGFnWvmQfJumJ4BOdBduqeUm8vmw/edit?usp=sharing.
This is the link of the document I prepared. Hope it helps you understand the problem faced.

@veena14cs PTAL at this issue.

@veena14cs This is the link to document.
https://docs.google.com/document/d/12vTSL8eW9LMtPmxSGFnWvmQfJumJ4BOdBduqeUm8vmw/edit?usp=sharing
Thanks.

[virajpatel2411]

@rt4914 https://docs.google.com/document/d/12vTSL8eW9LMtPmxSGFnWvmQfJumJ4BOdBduqeUm8vmw/edit?usp=sharing.
This is the link of the document I prepared. Hope it helps you understand the problem faced.

@veena14cs PTAL at this issue.

@veena14cs This is the link to document.
https://docs.google.com/document/d/12vTSL8eW9LMtPmxSGFnWvmQfJumJ4BOdBduqeUm8vmw/edit?usp=sharing
Thanks.

@rt4914 @veena14cs Any updates?

[veena14cs]

https://docs.google.com/document/d/12vTSL8eW9LMtPmxSGFnWvmQfJumJ4BOdBduqeUm8vmw/edit?usp=sharing

@virajpatel2411 I checked the document will figure this out, till then you can pick out some new issue and start working on it. Once we figure out, I will update you on this.

[virajpatel2411]

https://docs.google.com/document/d/12vTSL8eW9LMtPmxSGFnWvmQfJumJ4BOdBduqeUm8vmw/edit?usp=sharing

@virajpatel2411 I checked the document will figure this out, till then you can pick out some new issue and start working on it. Once we figure out, I will update you on this.

@veena14cs Okay.

[anandwana001]

@virajpatel2411 I tried CompletedStoryListActivityTest running Robolectric test and yes, it passed only 1 out of 9 in my case. I annotated @LooperMode(PAUSED) annotation on the top of the class and it passed all the test cases under Robolectric Testing

added androidTestImplementation 'org.robolectric:annotations:4.3.1'

Documentation of Robolectric Looper

Reference to this Robolectric Issue

LooperMode class

Robolectric Result

Espresso Result

[virajpatel2411]

@anandwana001 Okay. So, now is there anything to do from my side or the issue now is resolved?

[anandwana001]

RevisionCardFragmentTest works fine

Robolectric

Espresso

[prayutsu]

I am taking up OptionsFragmentTest

[Sarthak2601]

@rt4914 Since we are going to take this issue under SLoP, can we freeze its contributions for now ? It might lead to confusion otherwise.
@prayutsu Please wait on Rajat to reply.
/cc- @anandwana001

[anandwana001]

@rt4914 Since we are going to take this issue under SLoP, can we freeze its contributions for now ? It might lead to confusion otherwise.
@prayutsu Please wait on Rajat to reply.
/cc- @anandwana001

Sounds good

[Sarthak2601]

@BenHenning should we include StateFragementTest in the tests for the SLoP participants to fix or you're working on it ?

[BenHenning]

@Sarthak2601 StateFragmentTest is fixed & running (as of #1630). Thanks for checking.

That being said, #388 & https://github.com/oppia/oppia-android/blob/develop/app/src/sharedTest/java/org/oppia/app/player/state/StateFragmentTest.kt#L206 might be a great set of tests that could be split into starter issues for SLoP. Ditto for question player (#503). #1273 also needs to be done (hints & solutions tests for questions).

@rt4914 we talked about not adding missing test cases, but much of the above is already figured out & immediately high impact since it covers the core learner experiences. It seems worth finishing that work.

Another unrelated area of work that I thought of: creating common test dependencies for matchers, shared modules, and shared utility functions (especially the ones used between state & question players).

[rt4914]

Closing this issue as we have created separate issues:
#1868 #1869 #1870 #1871 #1872 #1873 #1874 #1877 #1878