Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqlite): enable foreign keys for sqlite #98

Merged
merged 1 commit into from
Oct 14, 2019
+6 −4
Merged

fix(sqlite): enable foreign keys for sqlite #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions pkg/sqlite/load.go
View file
Original file line number Diff line number Diff line change
@@ -35,7 +35,7 @@ func NewSQLLiteLoader(outFilename string) (*SQLLoader, error) {
CREATE TABLE IF NOT EXISTS package (
name TEXT PRIMARY KEY,
default_channel TEXT,
FOREIGN KEY(default_channel) REFERENCES channel(name)
FOREIGN KEY(name, default_channel) REFERENCES channel(package_name,name)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

referencing a field that's part of a compound primary key requires referencing the full primary key - this was the main issue.

);
CREATE TABLE IF NOT EXISTS channel (
name TEXT,
@@ -53,9 +53,7 @@ func NewSQLLiteLoader(outFilename string) (*SQLLoader, error) {
replaces INTEGER,
depth INTEGER,
FOREIGN KEY(replaces) REFERENCES channel_entry(entry_id) DEFERRABLE INITIALLY DEFERRED,
FOREIGN KEY(channel_name) REFERENCES channel(name),
FOREIGN KEY(package_name) REFERENCES channel(package_name),
FOREIGN KEY(operatorbundle_name) REFERENCES operatorbundle(name)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to remove the foreign key to operator_bundle, since synthesized channel entries for skiped releases may not have a corresponding bundle.

FOREIGN KEY(channel_name, package_name) REFERENCES channel(name, package_name)
);
CREATE TABLE IF NOT EXISTS api (
group_name TEXT,
@@ -74,6 +72,10 @@ func NewSQLLiteLoader(outFilename string) (*SQLLoader, error) {
);
`

if _, err := db.Exec("PRAGMA foreign_keys = ON", nil); err != nil {
return nil, err
}

if _, err = db.Exec(createTable); err != nil {
return nil, err
}