fix(sqlite): enable foreign keys for sqlite #98
Merged
+6
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
approved
ecordell
commented
Oct 12, 2019
| @@ -35,7 +35,7 @@ func NewSQLLiteLoader(outFilename string) (*SQLLoader, error) { | |||
| CREATE TABLE IF NOT EXISTS package ( | |||
| name TEXT PRIMARY KEY, | |||
| default_channel TEXT, | |||
| FOREIGN KEY(default_channel) REFERENCES channel(name) | |||
| FOREIGN KEY(name, default_channel) REFERENCES channel(package_name,name) | |||
There was a problem hiding this comment.
referencing a field that's part of a compound primary key requires referencing the full primary key - this was the main issue.
ecordell
commented
Oct 12, 2019
| @@ -53,9 +53,7 @@ func NewSQLLiteLoader(outFilename string) (*SQLLoader, error) { | |||
| replaces INTEGER, | |||
| depth INTEGER, | |||
| FOREIGN KEY(replaces) REFERENCES channel_entry(entry_id) DEFERRABLE INITIALLY DEFERRED, | |||
| FOREIGN KEY(channel_name) REFERENCES channel(name), | |||
| FOREIGN KEY(package_name) REFERENCES channel(package_name), | |||
| FOREIGN KEY(operatorbundle_name) REFERENCES operatorbundle(name) | |||
There was a problem hiding this comment.
Had to remove the foreign key to operator_bundle, since synthesized channel entries for skiped releases may not have a corresponding bundle.
gallettilance
approved these changes
Oct 14, 2019
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, gallettilance, njhale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Foreign key constraints were not being enforced - thanks @gallettilance for finding this issue!
There were a couple of problems with the foreign keys that are fixed in this PR
Motivation for the change:
We want to rely on sqlite's enforcement of foreign keys so that we don't need to enforce them ourselves.
Reviewer Checklist
/docs