Strengthen module types #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonludlam
force-pushed
the
strengthen-module-types
branch
from
5944b44 to
4a4be2f
Compare
|
I think we might still be missing strengthening of class types too |
Julow
approved these changes
Sep 23, 2021
| | None -> Some (ModuleType.Path { p_path = prefix; p_expansion = None }) | ||
| | Some _ -> m.expr | ||
| in | ||
| let expr = Some (ModuleType.Path { p_path = prefix; p_expansion = None }) in |
There was a problem hiding this comment.
Should we keep m.expr into p_expansion ? What if m.expr is something complicated like With or TypeOf ?
There was a problem hiding this comment.
Alright, we don't need to keep the expansion around because it's getting recomputed anyway.
When strengthening a module, we now 'strengthen' module types too, so for all module types declared in `X`, if we're strenthening with `Y`, we replace e.g. for module type `A` in `X`, `X.A = sig ... end` with `X.A = Y.A`. These 'module type aliases' are then not expanded, resulting in a reduction in number of output files.
jonludlam
force-pushed
the
strengthen-module-types
branch
from
4a4be2f to
0b2facd
Compare
jonludlam
added a commit
to jonludlam/opam-repository
that referenced
this pull request
Oct 5, 2021
CHANGES: Breaking changes - Remove odoc-parser into a separate repository (@jonludlam, ocaml/odoc#700) Additions - OCaml 4.13 support (@Octachron, ocaml/odoc#687, ocaml/odoc#689) - Better errors/warnings (@Julow, ocaml/odoc#692, ocaml/odoc#717, ocaml/odoc#720, ocaml/odoc#732) - ModuleType 'Alias' support (@jonludlam, ocaml/odoc#703) - Improved test suite (@lubega-simon, ocaml/odoc#697) - Improved documentation (@lubega-simon, @jonludlam, ocaml/odoc#702, ocaml/odoc#733) - Strengthen module types (@jonludlam, ocaml/odoc#731) Bugs fixed - `uwt` now can be documented (@jonludlam, ocaml/odoc#708) - Fix resolution involving deeply nested substitutions (@jonludlam, ocaml/odoc#727) - Fix off-by-one error in error reporting (@asavahista, ocaml/odoc#736)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had thought I'd already done this!