Support for "with module type" constraints #689
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
with module type
constraint:and local module type substitution:
This change adds a new class of fragments for module types which explains the size of the new code.
There is some cases in
xref2/subst.ml
that would require more attention during review: there are few assertions about which module type paths can be substituted or not.One limitation of this PR is that deep destructive substitution is not supported. For instance,
creates a dead link
M.r
in the constrained signature. However, this is a global issue with all deep destructive substitutions. It seems better to fix this issue independently.