Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1b5b019
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f223bba
Choose a head ref

Commits on Apr 26, 2016

  1. doc: fix a typo in 5.10.1's changelog

    PR-URL: #6076
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Vladimir Varankin authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    063d306 View commit details
  2. doc: update openssl LICENSE using license-builder.sh

    * due to: openssl bump in 1f43478
    
    PR-URL: #6065
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    srl295 authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    beb5af2 View commit details
  3. deps: backport 125ac66 from v8 upstream

    As requested in #5221
    
    Original commit message:
    
      fix debug command processor wrt restart frame.
    
      R=jkummerow@chromium.org
      BUG=v8:4757
      LOG=N
    
      Review URL: https://codereview.chromium.org/1700693002
    
      Cr-Commit-Position: refs/heads/master@{#33983}
    
    PR-URL: #6086
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: MichaΓ«l Zasso <mic.besace@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Myles Borins authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    e6e1bf7 View commit details
  4. test: refactor test-file-write-stream3

    * use common.mustCall() to verify all tests have run
    * eliminate unneeded removeTestFile()
    * eliminate unneeded var leaking into global scope
    * var -> const
    * remove instance of let
    
    PR-URL: #6050
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    5679f4c View commit details
  5. doc: add example using algorithms not directly exposed

    PR-URL: #6108
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
    hillbrad authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    4305a23 View commit details
  6. buffer: standardize array index check

    ParseArrayIndex() was requesting a Uint32Value(), but assigning it to an
    in32_t. This caused slight differences in error message reported in edge
    cases of argument parsing. Fixed by getting the IntegerValue() before
    checking if the value is < 0. Added test of API that was affected.
    
    PR-URL: #6084
    Reviewed-By: James M Snell <jasnell@gmail.com>
    trevnorris authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    5b41230 View commit details
  7. doc: add topic - event loop, timers, nextTick()

    Adds a new topic that provides an overview of the event loop, timers, and
    `process.nextTick()` that is based upon a NodeSource "Need to Node" presentation
    hosted by @trevnorris: Event Scheduling and the Node.js Event
    Loop (https://nodesource.com/resources).
    
    PR-URL: #4936
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Calvin W. Metcalf <calvin.metcalf@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    techjeffharris authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    b89a285 View commit details
  8. repl: refactor repl.js

    There is some unnecessary logic in repl.js. Remove it.
    
    PR-URL: #6071
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    16f011e View commit details
  9. path: fixing a test that breaks on some machines.

    A win32-only test was verifying that path.win32._makeLong('C:')
    would return the current working directory.  This would only work if
    current working directory was also on the C: device.  Fix is to grab
    the device letter for current working directory, and pass that to
    _makeLong().
    
    PR-URL: #6067
    Reviewed-By: Trott - Rich Trott <rtrott@gmail.com>
    Reviewed-By: Joao Reis <reis@janeasystems.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Johan BergstrΓΆm <bugs@bergstroem.nu>
    Mike Kaufman authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    c4518ab View commit details
  10. tools: do not rewrite npm shebang in install.py

    Rewriting npm shebang in install.py violates user expectations
    among other things.
    
    The shebang in npm.js is kept as #!/usr/bin/env node.
    
    Fixes: #6095
    PR-URL: #6098
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Johan BergstrΓΆm <bugs@bergstroem.nu>
    evanlucas authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    102a776 View commit details
  11. test: fix flaky test-http-client-abort

    Fixes: #6080
    PR-URL: #6124
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    7ce9670 View commit details
  12. test: move some test from sequential to parallel

    The only test with modifications is `test-stdin-child-proc` that was
    passing when it should not because the exit code of the child process
    was not being checked.
    
    PR-URL: #6087
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Johan BergstrΓΆm <bugs@bergstroem.nu>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
    santigimeno authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    720b8f0 View commit details
  13. doc: path.format provide more examples

    This change was to add upon the algorithm description of path.format
    by adding examples for unix systems that clarified behavior in
    various scenarios.
    
    PR-URL: #5838
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
    eversojk authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    dd4b0e5 View commit details
  14. buffer: add Buffer.prototype.compare by offset

    Adds additional `targetStart`, `targetEnd`, `sourceStart,
    and `sourceEnd` arguments to `Buffer.prototype.compare`
    to allow comparison of sub-ranges of two Buffers without
    requiring Buffer.prototype.slice()
    
    Fixes: #521
    PR-URL: #5880
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    jasnell committed Apr 26, 2016
    Copy the full SHA
    6832078 View commit details
  15. doc: fix scrolling on iOS devices

    Fixes an issue that prevented scrolling from going past large code
    blocks on iOS devices. Also fixes a few minor styling issues that
    came up in the discussion.
    
    Fixes: #5861
    PR-URL: #5878
    Reviewed-By: Roman Reiss <me@silverwind.io>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Robert LindstΓ€dt <robert.lindstaedt@gmail.com>
    lpinca authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    e865488 View commit details
  16. tools,doc: fix incomplete json produced by doctool

    Doc tool produces incomplete json when it meets unordered lists that
    directly following a heading. Add a default case to processList function
    to handle the lists.
    
    PR-URL: #5966
    Fixes: #1545
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Robert LindstΓ€dt <robert.lindstaedt@gmail.com>
    Reviewed-By: Roman Reiss <me@silverwind.io>
    firedfox authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    8a19569 View commit details
  17. tools,doc: fix json for grouped optional params

    Current tools/doc/json.js only supports one bracket style for optional
    params methodName(param0[,param1],param2). Add support to other styles
    such as methodName(param0,[param1,]param2) or
    methodName(param0[,param1,param2]) or
    methodName(param0[,param1[,param2]]).
    
    PR-URL: #5977
    Fixes: #5976
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Robert LindstΓ€dt <robert.lindstaedt@gmail.com>
    Reviewed-By: Roman Reiss <me@silverwind.io>
    firedfox authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    bcb37f0 View commit details
  18. doc: describe child.kill() pitfalls on linux

    This commit refines the documentation around child.kill(), where kill
    attempts against shells will lead to unexpected results. Namely, on
    linux the child process of a child process will not terminate, when
    its parent gets terminated. This is different across the the
    platforms.
    
    PR-URL: #2098
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Closes: #2098
    eljefedelrodeodeljefe authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    d66d028 View commit details
  19. tools: update ESLint to 2.7.0

    PR-URL: #6132
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: thefourtheye <thechargingvolcano@gmail.com>
    silverwind authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    128f582 View commit details
  20. test: fix issues for ESLint 2.7.0

    PR-URL: #6132
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: thefourtheye <thechargingvolcano@gmail.com>
    silverwind authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    1ecb0ab View commit details
  21. doc: clarification for maxBuffer and Unicode output

    Clarify caveats on `maxBuffer` with regards to Unicode output.
    
    Refs: #1901
    PR-URL: #6030
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    jasnell committed Apr 26, 2016
    Copy the full SHA
    aa1220d View commit details
  22. doc: add copy about how to curl SHA256.txt

    Currently we include instructions on how to check the sha of a
    downloaded tar-ball, but do not include instruction on how to
    get the `SHA256.txt` file. This has led to confusion with people
    thinking that the SHA256.txt is included in that tarball.
    
    This commit includes instructions on how to use curl to download the
    `SHA256.txt` prior to the instructions on how to verify the sha.
    
    Refs: nodejs/help#113
    Refs: nodejs/help#137
    PR-URL: #6120
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Myles Borins authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    677642e View commit details
  23. querystring: using toString for objects on querystring.escape

    This commit fixes an inconsistency in querystring.escape objects handling
    compared to native encodeURIComponent function.
    
    Fixes: #5309
    PR-URL: #5341
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Brian White <mscdex@mscdex.net>
    silentroach authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    5c8b597 View commit details
  24. stream: Fix readableState.awaitDrain mechanism

    In 6899094 (#2325),
    the conditions for increasing `readableState.awaitDrain` when
    writing to a piping destination returns false were changed so
    that they could not actually be met, effectively leaving
    `readableState.awaitDrain` with a constant value of 0.
    
    This patch changes the conditions to testing whether the
    stream for which `.write()` returned false is still a piping
    destination, which was likely the intention of the original
    patch.
    
    Fixes: #5820
    Fixes: #5257
    PR-URL: #6023
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    fc1f481 View commit details
  25. tools: remove simplejson dependency

    As Node.js expects either Python 2.6 or 2.7 installed to work properly,
    simplejson module is no longer necessary. It was included in Python 2.6
    as the json module.
    
    PR-URL: #6101
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Johan BergstrΓΆm <bugs@bergstroem.nu>
    thefourtheye authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    f6c9d15 View commit details
  26. test: fix flaky test-child-process-fork-net

    Reduce client connections from 10 to 4 in a test that is causing issues
    on Raspberry Pi 2 devices in CI.
    
    Fixes: #5122
    PR-URL: #6138
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Trott authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    5a26849 View commit details
  27. os: add userInfo() method

    os.userInfo() calls libuv's uv_os_get_passwd() function. It returns
    an object containing the current effective user's username, uid,
    gid, shell, and home directory. On Windows, the uid and gid are
    -1, and the shell is null.
    
    Refs: #5582
    PR-URL: #6104
    Reviewed-By: James M Snell <jasnell@gmail.com>
    cjihrig authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    e052096 View commit details
  28. deps: cherry-pick 1383d00 from v8 upstream

    Original commit message:
    
        tools: fix tickprocessor Cpp symbols on mac
    
        Despite man page documentation:
    
            -f Display the symbol table of a dynamic library flat (as one
               file not separate modules).
    
        `nm` on mac treats `-f` as a shorthand for `-format`. The `-f` argument
        does not seem to be required, so just remove it completely.
    
        (For `-format` documentation - see `nm --help` on mac).
    
        BUG=
    
        Review URL: https://codereview.chromium.org/1840633002
    
        Cr-Commit-Position: refs/heads/master@{#35445}
    
    Fix: #5903
    PR-URL: #6179
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: MichaΓ«l Zasso <mic.besace@gmail.com>
    indutny authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    71bdf86 View commit details
  29. streams: support unlimited synchronous cork/uncork cycles

    net streams can request multiple chunks to be written in a synchronous
    fashion. If this is combined with cork/uncork, en error is currently
    thrown because of a regression introduced in:
    89aeab9
    (#4354).
    
    Fixes: #6154
    PR-URL: #6164
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Mathias Buus <mathiasbuus@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mcollina authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    49efb20 View commit details
  30. repl: don’t complete non-simple expressions

    Change the regular expression that recognizes β€œsimple” JS expressions
    to requiring that the full line needs to match it.
    
    Previously, in terms like `a().b.`, `b.` would be a partial match.
    This meant that completion would evaluate `b` and either fail with
    a `ReferenceError` or, if `b` was some global, return the properties
    of the global `b` object.
    
    PR-URL: #6192
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    addaleax authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    4f5bb8b View commit details
  31. doc: fix incorrect references in buffer docs

    PR-URL: #6194
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Reviewed-By: MichaΓ«l Zasso <mic.besace@gmail.com>
    Amery2010 authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    604625d View commit details
  32. deps: upgrade npm to 3.8.6

    PR-URL: #6153
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    zkat authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    a17bddf View commit details
  33. deps: floating fix for npm's test-node script

    Upstream PR: npm/npm#12310
    
    PR-URL: #6153
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    zkat authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    e4abf8a View commit details
  34. deps: upgrade V8 to 5.0.71.32

    * Pick up the branch head for V8 5.0 stable [1]
    * Edit v8 gitignore to allow trace_event copy
    * Update V8 DEP trace_event as per deps/v8/DEPS [2]
    
    [1] https://chromium.googlesource.com/v8/v8.git/+/3c67831
    [2] https://chromium.googlesource.com/chromium/src/base/trace_event/common/+/4b09207e447ae5bd34643b4c6321bee7b76d35f9
    
    Ref: #5945
    PR-URL: #6111
    Reviewed-By: targos - MichaΓ«l Zasso <mic.besace@gmail.com>
    Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
    ofrobots authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    a42453b View commit details
  35. test: update error message for JSON.parse

    V8 5.0 introduced a small modification for the unexpected end of input
    error.
    
    PR-URL: #5945
    Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
    targos authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    3ebabc9 View commit details
  36. debugger: run last command on presssing enter

    PR-URL: #6090
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Fixes: #2895
    Trott authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    3479eee View commit details
  37. benchmark: add module loader benchmark parameter

    PR-URL: #5172
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mscdex authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    4ea792a View commit details
  38. lib: improve module loading performance

    This commit improves module loading performance by at least ~25-35%
    in the module-loader benchmarks.
    
    Some optimization strategies include:
    * Try-finally/try-catch isolation
    * Replacing regular expressions with manual parsing
    * Avoiding unnecessary string and array creation
    * Avoiding constant recompilation of anonymous functions and
    function definitions within functions
    
    PR-URL: #5172
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mscdex authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    c29b3c1 View commit details
  39. src: add SIGINFO to supported signals

    Though not a POSIX signal, SIGINFO is supported by BSD systems
    (including Mac OS X) and is amongst the few signals that can be
    triggered in a terminal via a simple key combination (CTRL-T).
    
    On Linux, SIGINFO is an alias for SIGPWR; hence the defensive
    conditionals in src/node.cc.
    
    PR-URL: #6093
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    jamesreggio authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    6e76419 View commit details
  40. test: move debugger tests to sequential

    The debugger tests in parallel fail with `make test` sometimes (all the
    time?). This appears to be related to running in parallel, as it does
    not fail with `make test-ci`, when run via `tools/test.py` or directly
    from the command line with `./node
    test/parallel/test-debugger-util-regression.js`.
    
    A separate issue may be opened to find out why it is failing in
    parallel, but for now, I think it's important to fix `make test`
    promptly.
    
    I suspect the issue is that the tests are relying on a default port
    somewhere and so they are colliding when run in parallel. But that's
    just a guess for the moment.
    
    PR-URL: #6205
    Fixes: #6201
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Johan BergstrΓΆm <bugs@bergstroem.nu>
    Trott authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    5cce87d View commit details
  41. tools: improve js linter

    This commit switches from the eslint command-line tool to a custom
    tool that uses eslint programmatically in order to perform linting
    in parallel and to display linting results incrementally instead of
    buffering them until the end.
    
    Fixes: #5596
    PR-URL: #5638
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Johan BergstrΓΆm <bugs@bergstroem.nu>
    mscdex authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    396fbeb View commit details
  42. fs: optimize realpath using uv_fs_realpath()

    Remove realpath() and realpathSync() cache.
    Use the native uv_fs_realpath() which is faster
    then the JS implementation by a few orders of magnitude.
    
    PR-URL: #3594
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Johan BergstrΓΆm <bugs@bergstroem.nu>
    jhamhader authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    a2492f9 View commit details
  43. buffer: add Buffer.allocUnsafeSlow(size)

    Aligns the functionality of SlowBuffer with the new Buffer
    constructor API. Next step is to docs-only deprecate
    SlowBuffer.
    
    Replace the internal uses of SlowBuffer with
    `Buffer.allocUnsafeSlow(size)`
    
    PR-URL: #5833
    Reviewed-By: Π‘ΠΊΠΎΠ²ΠΎΡ€ΠΎΠ΄Π° Никита АндрССвич <chalkerx@gmail.com>
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    jasnell committed Apr 26, 2016
    Copy the full SHA
    d0c6e6f View commit details
  44. buffer: docs-only deprecate SlowBuffer

    With the addition of `Buffer.allocUnsafeSlow(size)`
    `SlowBuffer` can be deprecated... but docs-only for now.
    
    PR-URL: #5833
    Reviewed-By: Π‘ΠΊΠΎΠ²ΠΎΡ€ΠΎΠ΄Π° Никита АндрССвич <chalkerx@gmail.com>
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    jasnell committed Apr 26, 2016
    Copy the full SHA
    829d613 View commit details
  45. doc: minor copy improvement in buffer.markdown

    PR-URL: #5833
    Reviewed-By: Π‘ΠΊΠΎΠ²ΠΎΡ€ΠΎΠ΄Π° Никита АндрССвич <chalkerx@gmail.com>
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    jasnell committed Apr 26, 2016
    Copy the full SHA
    34b1a64 View commit details
  46. doc: add addaleax to collaborators

    PR-URL: #6224
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    addaleax authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    8b5acd5 View commit details
  47. doc: add santigimeno to collaborators

    PR-URL: #6225
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    santigimeno authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    4d52eae View commit details
  48. doc: add iWuzHere to collaborators

    PR-URL: #6226
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    imran-iq authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    3c5c3d0 View commit details
  49. doc: add stefanmb to collaborators

    PR-URL: #6227
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    stefanmb authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    28003bf View commit details
  50. doc: add domain postmortem

    Do to various reasons, outlined in the committed document, domains were
    only in core for 2 years before being deprecated. This outline explains
    why they received criticism from the community and never gained traction
    with module authors.
    
    Also included is an example script that accompanies the postmortem
    analysis.
    
    PR-URL: #6159
    Reviewed-By: Robert LindstΓ€dt <robert.lindstaedt@gmail.com>
    Reviewed-By: Kelvin Knighton <keltheceo@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Brian White <mscdex@mscdex.net>
    trevnorris authored and jasnell committed Apr 26, 2016
    Copy the full SHA
    e8117ec View commit details
Showing 11,996 changed files with 1,472,770 additions and 394,904 deletions.
The diff you're trying to view is too large. We only load the first 3000 changed files.
7 changes: 4 additions & 3 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -4,13 +4,11 @@ root = true
end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true

[vcbuild.bat]
end_of_line = crlf

[*.{md,markdown}]
trim_trailing_whitespace = false

[{lib,src,test}/**.js]
indent_style = space
indent_size = 2
@@ -37,3 +35,6 @@ indent_size = ignore
end_of_line = ignore
trim_trailing_whitespace = ignore
charset = ignore

[{test/fixtures,deps,tools/eslint,tools/gyp,tools/icu,tools/msvs}/**]
insert_final_newline = false
7 changes: 4 additions & 3 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
lib/internal/v8_prof_polyfill.js
lib/internal/v8_prof_processor.js
lib/punycode.js
test/addons/??_*/
test/fixtures
test/**/node_modules
test/disabled
test/tmp*/
tools/doc/node_modules
tools/eslint
node_modules
benchmark/tmp/
doc/**/*.js
110 changes: 0 additions & 110 deletions .eslintrc

This file was deleted.

187 changes: 187 additions & 0 deletions .eslintrc.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,187 @@
root: true

plugins:
- markdown

env:
node: true
es6: true

parserOptions:
ecmaVersion: 2016

rules:
# Possible Errors
# http://eslint.org/docs/rules/#possible-errors
comma-dangle: [error, only-multiline]
no-control-regex: error
no-debugger: error
no-dupe-args: error
no-dupe-keys: error
no-duplicate-case: error
no-empty-character-class: error
no-ex-assign: error
no-extra-boolean-cast: error
no-extra-parens: [error, functions]
no-extra-semi: error
no-func-assign: error
no-invalid-regexp: error
no-irregular-whitespace: error
no-obj-calls: error
no-proto: error
no-template-curly-in-string: error
no-unexpected-multiline: error
no-unreachable: error
no-unsafe-negation: error
use-isnan: error
valid-typeof: error

# Best Practices
# http://eslint.org/docs/rules/#best-practices
dot-location: [error, property]
no-fallthrough: error
no-global-assign: error
no-multi-spaces: [error, {ignoreEOLComments: true}]
no-octal: error
no-redeclare: error
no-self-assign: error
no-unused-labels: error
no-useless-call: error
no-useless-concat: error
no-useless-escape: error
no-useless-return: error
no-void: error
no-with: error

# Strict Mode
# http://eslint.org/docs/rules/#strict-mode
strict: [error, global]

# Variables
# http://eslint.org/docs/rules/#variables
no-delete-var: error
no-undef: error
no-unused-vars: [error, {args: none}]
no-use-before-define: [error, {classes: true,
functions: false,
variables: false}]

# Node.js and CommonJS
# http://eslint.org/docs/rules/#nodejs-and-commonjs
no-mixed-requires: error
no-new-require: error
no-path-concat: error
no-restricted-modules: [error, sys, _linklist]
no-restricted-properties:
- error
- object: assert
property: deepEqual
message: Use assert.deepStrictEqual().
- object: assert
property: equal
message: Use assert.strictEqual() rather than assert.equal().
- object: assert
property: notEqual
message: Use assert.notStrictEqual() rather than assert.notEqual().
- property: __defineGetter__
message: __defineGetter__ is deprecated.
- property: __defineSetter__,
message: __defineSetter__ is deprecated.

# Stylistic Issues
# http://eslint.org/docs/rules/#stylistic-issues
block-spacing: error
brace-style: [error, 1tbs, {allowSingleLine: true}]
comma-spacing: error
comma-style: error
computed-property-spacing: error
eol-last: error
func-call-spacing: error
func-name-matching: error
func-style: [error, declaration, {allowArrowFunctions: true}]
indent: [error, 2, {ArrayExpression: first,
CallExpression: {arguments: first},
FunctionDeclaration: {parameters: first},
FunctionExpression: {parameters: first},
MemberExpression: off,
ObjectExpression: first,
SwitchCase: 1}]
key-spacing: [error, {mode: minimum}]
keyword-spacing: error
linebreak-style: [error, unix]
max-len: [error, {code: 80,
ignoreRegExpLiterals: true,
ignoreUrls: true,
tabWidth: 2}]
new-parens: error
no-mixed-spaces-and-tabs: error
no-multiple-empty-lines: [error, {max: 2, maxEOF: 0, maxBOF: 0}]
no-restricted-syntax: [error, {
selector: "CallExpression[callee.object.name='assert'][callee.property.name='throws'][arguments.1.type='Literal']:not([arguments.1.regex])",
message: "use a regular expression for second argument of assert.throws()"
}, {
selector: "CallExpression[callee.object.name='assert'][callee.property.name='throws'][arguments.length<2]",
message: "assert.throws() must be invoked with at least two arguments."
}, {
selector: "CallExpression[callee.name='setTimeout'][arguments.length<2]",
message: "setTimeout() must be invoked with at least two arguments."
}, {
selector: "CallExpression[callee.name='setInterval'][arguments.length<2]",
message: "setInterval() must be invoked with at least 2 arguments."
}, {
selector: "ThrowStatement > CallExpression[callee.name=/Error$/]",
message: "Use new keyword when throwing an Error."
}]
no-tabs: error
no-trailing-spaces: error
operator-linebreak: [error, after, {overrides: {'?': ignore, ':': ignore}}]
quotes: [error, single, avoid-escape]
semi: error
semi-spacing: error
space-before-blocks: [error, always]
space-before-function-paren: [error, {
"anonymous": "never",
"named": "never",
"asyncArrow": "always"
}]
space-in-parens: [error, never]
space-infix-ops: error
space-unary-ops: error

# ECMAScript 6
# http://eslint.org/docs/rules/#ecmascript-6
arrow-parens: [error, always]
arrow-spacing: [error, {before: true, after: true}]
constructor-super: error
no-class-assign: error
no-confusing-arrow: error
no-const-assign: error
no-dupe-class-members: error
no-new-symbol: error
no-this-before-super: error
prefer-const: [error, {ignoreReadBeforeAssign: true}]
rest-spread-spacing: error
template-curly-spacing: error

# Custom rules in tools/eslint-rules

# Global scoped method and vars
globals:
COUNTER_HTTP_CLIENT_REQUEST: false
COUNTER_HTTP_CLIENT_RESPONSE: false
COUNTER_HTTP_SERVER_REQUEST: false
COUNTER_HTTP_SERVER_RESPONSE: false
COUNTER_NET_SERVER_CONNECTION: false
COUNTER_NET_SERVER_CONNECTION_CLOSE: false
DTRACE_HTTP_CLIENT_REQUEST: false
DTRACE_HTTP_CLIENT_RESPONSE: false
DTRACE_HTTP_SERVER_REQUEST: false
DTRACE_HTTP_SERVER_RESPONSE: false
DTRACE_NET_SERVER_CONNECTION: false
DTRACE_NET_STREAM_END: false
LTTNG_HTTP_CLIENT_REQUEST: false
LTTNG_HTTP_CLIENT_RESPONSE: false
LTTNG_HTTP_SERVER_REQUEST: false
LTTNG_HTTP_SERVER_RESPONSE: false
LTTNG_NET_SERVER_CONNECTION: false
LTTNG_NET_STREAM_END: false
24 changes: 12 additions & 12 deletions .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
<!--
Thanks for wanting to report an issue you've found in Node.js. Please fill in
the template below by replacing the html comments with an appropriate answer.
If unsure about something, just do as best as you're able.
Thank you for reporting an issue.
version: usually output of `node -v`
platform: either `uname -a` output, or if Windows, version and 32 or 64-bit.
subsystem: optional -- if known please specify affected core module name.
This issue tracker is for bugs and issues found within Node.js core.
If you require more general support please file an issue on our help
repo. https://github.com/nodejs/help
It will be much easier for us to fix the issue if a test case that reproduces
the problem is provided. Ideally this test case should not have any external
dependencies. We understand that it is not always possible to reduce your code
to a small test case, but we would appreciate to have as
much data as possible.
Thank you!
Please fill in as much of the template below as you're able.
Version: output of `node -v`
Platform: output of `uname -a` (UNIX), or version and 32 or 64-bit (Windows)
Subsystem: if known, please specify affected core module name
If possible, please provide code that demonstrates the problem, keeping it as
simple and free of external dependencies as you are able.
-->

* **Version**:
Loading