Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debugger: pressing enter doesn't run the latest action #2895

Closed
IonicaBizau opened this issue Sep 16, 2015 · 4 comments
Closed

debugger: pressing enter doesn't run the latest action #2895

IonicaBizau opened this issue Sep 16, 2015 · 4 comments
Labels
feature request Issues that request new features to be added to Node.js.

Comments

@IonicaBizau
Copy link
Contributor

In debugger, after pressing n and then enter it goes to the next instruction which is fine. But when pressing enter again would be nice to execute the latest action (in this case next), like in the older versions. Here is a gif animation using 5.0.0-pre. But the issue is reproducible in 4.0.0.

output

@brendanashworth brendanashworth added debugger feature request Issues that request new features to be added to Node.js. labels Sep 16, 2015
@claudiorodriguez
Copy link
Contributor

Seems like the code for this is in https://github.com/nodejs/node/blob/master/lib/_debugger.js lines 946-950 (unless I'm reading it wrong), would have to debug the debugger to know more

@IonicaBizau
Copy link
Contributor Author

debug the debugger–sounds strange, but yeah, it's true. 😁

@Trott Trott mentioned this issue Apr 6, 2016
Closed
4 tasks
@Trott
Copy link
Member

Trott commented Apr 7, 2016

Proposed fix: #6090

Trott added a commit to Trott/io.js that referenced this issue Apr 9, 2016
@Trott
debugger: run last command on presssing enter
51fdc49 
Fixes: nodejs#2895
@Trott Trott closed this as completed in 1df84f4 Apr 14, 2016
@Trott
Copy link
Member

Trott commented Apr 14, 2016

This is fixed on master in 1df84f4

MylesBorins pushed a commit that referenced this issue Apr 20, 2016
@Trott
debugger: run last command on presssing enter
1fb4052 
PR-URL: #6090
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Fixes: #2895
MylesBorins pushed a commit that referenced this issue Apr 21, 2016
@Trott @MylesBorins
debugger: run last command on presssing enter

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
5c9dddf 
PR-URL: #6090
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Fixes: #2895
jasnell pushed a commit that referenced this issue Apr 26, 2016
@Trott @jasnell
debugger: run last command on presssing enter
3479eee 
PR-URL: #6090
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Fixes: #2895
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Issues that request new features to be added to Node.js.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

debugger: run last command on pressing enter Trott/io.js
4 participants
@Trott @IonicaBizau @brendanashworth @claudiorodriguez