fix when fetching tag and unspecified branch #199
Conversation
|
It doesn't seem it's possible in poetry to specify both a rev and a ref ? for htis reason I can't fetch some specific revisions that are not on the default branch. EDIT: no it works I was just using wrong nomenclature, |
| if isGit then | ||
| ( | ||
| builtins.fetchGit { | ||
| builtins.fetchGit (lib.debug.traceValSeq ({ |
There was a problem hiding this comment.
This should be not left it no, no?
There was a problem hiding this comment.
yes it should go away :) I am not sure this whole PR is a definitive fix nor how to operate/update the tests so I dont intend to complete this as of now. Anyone feel free to pick it up.
|
I think I have my final solution, if and only if there is a branch or tag add { ref = REF } (with REF=refs/tags/TAG if a tag) and nothing otherwise (I tried to pass ref=null instead of ref="HEAD": but nix doesnt like it). |
This has now been merged on master in #240 |
follow up of #167 . Explanation at #197 . I would like to update the tests but not sure what's best.