Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: poetry wouldn't work when using a tag #167

Closed
wants to merge 1 commit into from

Conversation

teto
Copy link

@teto teto commented Aug 31, 2020

fixes #160

I copy/pasted the patch from my fork of nixpkgs here and could not properly test.

@teto
Copy link
Author

teto commented Sep 8, 2020

@adisbladis I am trying to write tests for this to convince you (and also fixed an issue in my previous PR).
I've been running nix-build tests/default.nix but if fails with unknown package cppy ?
upon entering nix-shell, nixpkgs is overriden to one that doesn't seem valid but if I restore nixpkgs to my local checkout with export NIX_PATH=nixpkgs=/home/teto/nixpkgs (a nixos-unstable fork) tests work again. Not sure what's wrong, I never used niv.

@teto
Copy link
Author

teto commented Sep 8, 2020

while writing the test #171 for this, it seemed like poetry works already fine so don't merge this yet. I wonder if the error I had was not a sideeffect of python-poetry/poetry#2062 in fact.

@teto
Copy link
Author

teto commented Sep 28, 2020

doesn't seem needed after all, I wonder if I got mystified by a mismatched locked file and pyproject.toml. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

does poetry2nix support {git = ... tag = ...} packages ?
1 participant