Add unique IDs to edges #1866
Merged
Add unique IDs to edges #1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edges are nominally ordered by order in the build manifest, but in fact are ordered by memory address. In most cases the memory address will be monontonically increasing. Since serialized build output will need unique IDs, add a monotonically increasing ID to edges, and use that for sorting instead of memory address.
Closed
kinke
added a commit
to symmetryinvestments/ldc
that referenced
this pull request
Mar 21, 2022
Primarily for a deterministic and predictable build order: ninja-build/ninja#1866 That PR hasn't landed in any official release yet.
kinke
added a commit
to symmetryinvestments/ldc
that referenced
this pull request
Mar 21, 2022
Primarily for a deterministic and predictable build order: ninja-build/ninja#1866 That PR hasn't landed in any official release yet.
kinke
added a commit
to symmetryinvestments/ldc
that referenced
this pull request
Mar 21, 2022
Primarily for a deterministic and predictable build order: ninja-build/ninja#1866 That PR hasn't landed in any official release yet.
kinke
added a commit
to symmetryinvestments/ldc
that referenced
this pull request
Mar 21, 2022
Primarily for a deterministic and predictable build order: ninja-build/ninja#1866 That PR hasn't landed in any official release yet.
kinke
added a commit
to symmetryinvestments/ldc
that referenced
this pull request
Mar 21, 2022
Primarily for a deterministic and predictable build order: ninja-build/ninja#1866 That PR hasn't landed in any official release yet.
kinke
added a commit
to symmetryinvestments/ldc
that referenced
this pull request
Mar 21, 2022
Primarily for a deterministic and predictable build order: ninja-build/ninja#1866 That PR hasn't landed in any official release yet.
kinke
added a commit
to symmetryinvestments/ldc
that referenced
this pull request
May 16, 2022
ninja-build/ninja#2019, rebased onto latest master (including ninja-build/ninja#1866 for a deterministic and predictable build order, which hasn't landed in any official release yet).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first commit from #1210 by @colincross cherry-picked on master. I think unique edge IDs are a good idea not only for serialized build output, but for coming up with different build orders, too. Also memory address order isn't reliable.