-
-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ninja fails to order dependencies correctly for main.cc when BUILD_BUILTIN_CONFIG specified #1118
Comments
Manually running the text2c.sh script as per data/CMakeLists.txt, and creating the relevant header files, the build completes correctly, however, it's noticeable that main.cc is compiled -before- the text2c invocations triggered by CMake ! (further log to be re-uploaded) |
This change corrects dependencies on generated defconfig.h and/or convertconf.h header files because they must be generated before compilation of conky.cc and main.cc if BUILD_BUILTIN_CONFIG and/or BUILD_OLD_CONFIG are set. Fixes: brndnmtthws#1118
I heave the same problem for some time as well and I finally forced myself to look at it as I was curious why this affects only systems with build all: phony lua/all data/all doc/all 3rdparty/toluapp/all src/all tests/all
Anyway, I was curious what causes this difference in the build sequence and the reason is that |
@arkamar Dude, I owe you a few beers for this! Thanks! That's certainly a weird ole bug/feature .. but at least it's been found/fixed! Cheers! 🍻 |
@mjeveritt you're welcome! |
This change corrects dependencies on generated defconfig.h and/or convertconf.h header files because they must be generated before compilation of conky.cc and main.cc if BUILD_BUILTIN_CONFIG and/or BUILD_OLD_CONFIG are set. Fixes: #1118
This change corrects dependencies on generated defconfig.h and/or convertconf.h header files because they must be generated before compilation of conky.cc and main.cc if BUILD_BUILTIN_CONFIG and/or BUILD_OLD_CONFIG are set. Fixes: #1118
This change corrects dependencies on generated defconfig.h and/or convertconf.h header files because they must be generated before compilation of conky.cc and main.cc if BUILD_BUILTIN_CONFIG and/or BUILD_OLD_CONFIG are set. Fixes: #1118
This change corrects dependencies on generated defconfig.h and/or convertconf.h header files because they must be generated before compilation of conky.cc and main.cc if BUILD_BUILTIN_CONFIG and/or BUILD_OLD_CONFIG are set. Fixes: #1118
Issue
Cmake fails with:
when
BUILD_BUILTIN_CONFIG
and/orBUILD_OLD_CONFIG
is specifiedInformation
NB. This is not unique to v1.11.6, it just so happens this version is active/stable in Gentoo Linux at the time I am writing this, and build logs are readily available
The text was updated successfully, but these errors were encountered: