build: Migrate pytest configuration to pyproject.toml. #1588
Conversation
pyproject.toml
Outdated
| @@ -28,6 +28,33 @@ exclude = """(?x)( | |||
| | ^tests/balance_xdist_plugin\\.py$ # not part of our test suite. | |||
| )""" | |||
|
|
|||
| [tool.pytest.ini_options] | |||
| minversion = "6.0" | |||
There was a problem hiding this comment.
What does this do? It wasn't in the setup.cfg.
There was a problem hiding this comment.
There was a problem hiding this comment.
I'm not sure we need this setting, since we pin the version of pytest. I think it would be better to leave it out.
There was a problem hiding this comment.
Yeah, when I migrated our version, I included it to be on the safe side, but I agree this is likely ok to leave out.
|
Re the balanced_clumps section more generally, I wasn't sure how to know if the plugin is definitely working and configured, if that's what that section is about. Since I'm unsure if the test system would fail to run, or just not balance cleanly (using xdist?) if this config was not found in setup.cfg, but was present in pyproject.toml. |
neiljp
force-pushed
the
2023-03-20-setup.cfg-into-pyproject.toml
branch
from
efe5df2 to
44d7ca9
Compare
This works locally for me, but not all of the tox suite would run since the
.pipfiles won't reliably install (yet).However, the pytest suite runs locally on 3.9 just fine, so pushing this to see if it runs the CI test suite OK.